Repository navigation
Fix/issues 1172 1173 1174 1175 - #1239
Merged
Hexstar-labs merged 5 commits intoSep 28, 2026
Merged
Conversation
…es, Cargo.toml names, test imports, symbol compliance
…ull disbursement, over-withdrawal, fund-depletion boundary
…checked_mul_div_i128
…st/blacklist/emergency/limit combinations
|
@Yebom3220 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four related maintenance, refactoring, and test-coverage issues across the Soroban contracts.
Changes
#1172 — Clippy cleanup
#1173 — Scholarship fund disbursement edge-case tests
Added coverage for scholarship fund disbursement boundaries, including:
The tests verify that valid disbursements succeed while insufficient-fund scenarios are rejected correctly.
#1174 — Buyback calculation refactor
#1175 — Token restriction compliance tests
Expanded token restriction test coverage for the major transfer-compliance paths, including:
Scope
This PR is intentionally limited to the work associated with issues #1172–#1175. No new product functionality is introduced.
Verification
The implementation and tests were added for the affected contracts. Full workspace verification is currently affected by an existing Soroban SDK version mismatch between workspace members, so that environment issue has not been resolved as part of this PR.
Issues
Closes #1172
Closes #1173
Closes #1174
Closes #1175