Repository navigation
fix: code quality — remove unused deps, enforce clippy::pedantic, consolidate historical docs - #1238
Merged
Hexstar-labs merged 2 commits intoSep 28, 2026
Conversation
…pedantic, consolidate historical docs Resolves BrainTease#1200, BrainTease#1199, BrainTease#1198 ## BrainTease#1200 — Remove unused npm dependencies packages/types: - Remove `@types/jest` devDependency (redundant: ts-jest 29 provides jest types via its preset; `@types/jest` was never explicitly imported) apps/backend: - Remove `@eslint/js` devDependency (not referenced in .eslintrc.js or any source file; the project uses eslint-plugin-* and extends, not @eslint/js) - Remove `@nestjs/apollo` devDependency (GraphQL module uses @nestjs/graphql directly; @nestjs/apollo is never imported anywhere in src/) Retained after review (depcheck false-positives): - tailwindcss — used via tailwind.config.js + Next.js CSS pipeline - @chromatic-com/storybook, @storybook/addon-* — used as strings in .storybook/main.ts addons array (depcheck can't detect string references) - @vitest/coverage-v8 — used as provider = 'v8' string in vitest.config.ts - compression / @types/compression — imported in apps/backend/src/main.ts - @faker-js/faker — used in apps/backend/src/test/factories/ - testcontainers / tsconfig-paths — used in integration tests and seed scripts ## BrainTease#1199 — Enforce clippy::pedantic selectively across contracts workspace Cargo.toml: - Add [workspace.lints.clippy] table with 26 selected pedantic lints (warn level) that catch real correctness issues in #![no_std] Soroban contracts - Each enabled lint is annotated with a rationale comment - Lints skipped (with documented reasons): missing_errors_doc, missing_panics_doc, module_name_repetitions, must_use_candidate, wildcard_imports, too_many_lines, struct_excessive_bools, cast_possible_truncation, cast_sign_loss, cast_precision_loss contracts/*/Cargo.toml (all 19 contracts): - Add [lints] workspace = true so every contract crate inherits the workspace lint table without per-crate duplication clippy.toml: - Retain msrv = "1.70.0" - Add pointer comment directing readers to Cargo.toml for the lint list ## BrainTease#1198 — Consolidate scattered historical docs - Move 9 root-level IMPLEMENTATION_SUMMARY*.md and PR_DESC*.md files to docs/history/ (they are historical artifacts from issues BrainTease#626–BrainTease#841) - Add docs/history/README.md with a table-of-contents for the moved files - Update docs/README.md to reference the new docs/history/ section - Confirmed zero CI workflow, docs, or source references to these files (grep across .yml, .md, .json, .ts, .js returned no matches)
|
@marvel6828 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
marvel6828
had a problem deploying
to
preview-pr-1238
September 26, 2026 09:56 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Hexstar-labs
had a problem deploying
to
preview-pr-1238
September 28, 2026 08:59 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1200, #1199, #1198
Summary
Three code quality improvements in a single PR.
#1200 — Remove unused npm dependencies
packages/types@types/jestdevDependency — redundant with ts-jest 29 which bundles jest types via its preset; never directly imported in source filesapps/backend@eslint/jsdevDependency — not referenced in.eslintrc.jsor any source file (useseslint-plugin-*extends, not@eslint/js)@nestjs/apollodevDependency — never imported anywhere; the GraphQL module uses@nestjs/graphqldirectlyAll other depcheck flags verified as false-positives (storybook addons referenced as strings in config,
tailwindcssused via CSS pipeline,@vitest/coverage-v8used asprovider = 'v8'string, etc.)#1199 — Enforce clippy::pedantic selectively across contracts workspace
Cargo.toml[workspace.lints.clippy]table with 26 selected pedantic lints atwarnlevelmissing_errors_doc,missing_panics_doc,module_name_repetitions(ABI-breaking rename),must_use_candidate,wildcard_imports(idiomatic for soroban_sdk),cast_possible_truncation(required for SDK TTL/timestamp APIs), etc.All 19
contracts/*/Cargo.tomlfiles[lints] workspace = trueso every contract crate inherits the workspace lint table without per-crate duplicationclippy.tomlmsrv = "1.70.0"Cargo.tomlfor the full lint list#1198 — Consolidate scattered historical docs
IMPLEMENTATION_SUMMARY*.md,PR_DESC*.md,PR_DESCRIPTION*.md) todocs/history/docs/history/README.mdas a table-of-contents index for the moved filesdocs/README.mdwith a new "Historical Artifacts" section linking todocs/history/.yml,.md,.json,.ts,.jsreturned no matches)Checklist
[workspace.lints.clippy]workspace = truecloses #1200
closes #1199
closes #1198