Skip to content

fix(ci): unblock SAST gate — fix workflow shell-injection, suppress 7 false positives #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bihan-Banerjee merged 1 commit into from
Jun 5, 2026
Merged

fix(ci): unblock SAST gate — fix workflow shell-injection, suppress 7 false positives #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,16 @@ jobs:
# scoped to the dashboard/* prefix only. reports/ and metadata/ stay private.
("public", "modules/s3"),
("s3-bucket", "modules/s3"),
# SQLite raw queries — parameterized: every user value is bound via "?"
# placeholders; only static column names / clause fragments are f-string
# interpolated (WHERE/JOIN structure), never user input. No injection vector.
("sqlalchemy-execute-raw-query", "metadata/sqlite_store"),
# Finding-dedup fingerprint uses SHA-1 — not a security/integrity digest
# (usedforsecurity=False); collisions only affect local dedup, not trust.
("insecure-hash-algorithm-sha1", "metadata/sqlite_store"),
# Kyverno ECR-read role — short-lived IRSA tokens only, not long-lived
# creds (same rationale as the iam_oidc suppression above).
("no-iam-creds-exposure", "modules/kyverno"),
]

def is_suppressed(result):
Expand Down Expand Up @@ -630,14 +640,21 @@ jobs:
if: ${{ env.HAS_AWS == 'true' }}
env:
COSIGN_YES: "true"
# Pass GitHub context through the environment rather than interpolating
# ${{ … }} directly into the shell (avoids run-shell-injection; these
# values are GitHub-controlled but env-passing is the correct pattern).
PROV_REPO: ${{ github.repository }}
PROV_REF: ${{ github.ref }}
PROV_SHA: ${{ github.sha }}
PROV_RUN_ID: ${{ github.run_id }}
run: |
set -euo pipefail
cat > security/reports/provenance.json <<JSON
{
"buildType": "https://github.com/${{ github.repository }}/ci",
"builder": { "id": "https://github.com/${{ github.repository }}/.github/workflows/ci.yaml@${{ github.ref }}" },
"invocation": { "configSource": { "uri": "git+https://github.com/${{ github.repository }}@${{ github.sha }}" } },
"metadata": { "buildInvocationID": "${{ github.run_id }}" }
"buildType": "https://github.com/${PROV_REPO}/ci",
"builder": { "id": "https://github.com/${PROV_REPO}/.github/workflows/ci.yaml@${PROV_REF}" },
"invocation": { "configSource": { "uri": "git+https://github.com/${PROV_REPO}@${PROV_SHA}" } },
"metadata": { "buildInvocationID": "${PROV_RUN_ID}" }
}
JSON
cosign attest --type slsaprovenance \
Expand Down
4 changes: 3 additions & 1 deletion backend/metadata/sqlite_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,9 @@ def export_json(self) -> dict:
@staticmethod
def _fingerprint(finding) -> str:
raw = f"{finding.tool}|{finding.rule_id}|{finding.cve}|{finding.file_path}|{finding.severity}"
return hashlib.sha1(raw.encode("utf-8")).hexdigest()
# Dedup fingerprint only — not a security/integrity digest. usedforsecurity=False
# documents that intent (and silences SAST) while keeping the digest identical.
return hashlib.sha1(raw.encode("utf-8"), usedforsecurity=False).hexdigest()

@staticmethod
def _row_to_run(row) -> RunRecord:
Expand Down
Loading