Repository navigation
Fix spelling of social_security__recieves_goverment_assisted_scheme_payments - #201
Open
olitreadwell wants to merge 1 commit into
Open
olitreadwell wants to merge 1 commit into
olitreadwell wants to merge 1 commit into
Conversation
…ayments - Renamed social_security__recieves_goverment_assisted_scheme_payments to social_security__receives_government_assisted_scheme_payments. - Renamed social_security__recieves_main_benefit to social_security__receives_main_benefit. - Updated the matching local variable names in the social_security__financially_independent formula. - Fixed a typo in a variable label: Socal Security Act to Social Security Act. - No calculation logic changed, only names and one label string. - Bumped the version to 23.0.0 and added a CHANGELOG.md entry, since this is a breaking change for anyone using the old variable names (per CONTRIBUTING.md, renaming a variable is a major version bump). - Fixes BetterRules#137.
olitreadwell
force-pushed
the
fix/correct-variable-spelling
branch
from
August 12, 2026 04:09
857a3ef to
c3e5688
Compare
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical improvement.
Impacted periods: all.
Impacted areas:
openfisca_aotearoa/variables/acts/social_security/interpretation/financially_independentRenamed variables:
social_security__recieves_goverment_assisted_scheme_paymentsrenamed tosocial_security__receives_government_assisted_scheme_paymentssocial_security__recieves_main_benefitrenamed tosocial_security__receives_main_benefitsocial_security__financially_independentformula so everything stays consistent.social_security__recieves_goverment_assisted_scheme_payments,social_security__recieves_main_benefit) directly will need to switch to the new names. Per CONTRIBUTING.md, renaming a variable is a major version bump, so this PR also bumpspyproject.tomlfrom22.0.0to23.0.0and adds a matching CHANGELOG.md entry, following the format used by prior rename-only entries in this changelog. I searched the codebase (grep -rnacross.py,.yaml,.yml) and confirmed these two variable names are referenced nowhere else — no other variable files, no YAML tests — so this rename should not need any other code changes.Technical improvementlabel: I chose it because this is a pure rename with zero calculation impact (matches CONTRIBUTING.md's description: "formula syntax change... impacts the users who write legislation"). One historical precedent (v5.0.0) filed a similar pure-rename batch under "Tax and benefit system evolution" instead — happy to switch categories if a maintainer prefers that.CHANGELOG.mdif it lands as a different PR number.These changes:
How to verify
Checks run locally (Python 3.11.15, fresh venv)
python -m compileall -q .— PASSflake8— PASS, 0 findingspylint— PASS, 0 findingsyamllint— PASS, 0 findingsopenfisca test --country-package openfisca_aotearoa openfisca_aotearoa/tests— PASS, 313 passed, 0 failed (same count before and after the change)Confidence: HIGH
The rename is textually isolated to one file (confirmed by full-repo grep before and after), the full test suite and full lint suite pass unchanged, and the change follows this repo's own documented convention for variable renames (major version bump + CHANGELOG entry + no deprecation shim, confirmed against ~10 historical precedents in CHANGELOG.md). The only judgment calls are the changelog change-type label and the guessed PR number for the changelog's self-link, both called out above for maintainer review.