Fix GC reference tracking for injected classes - #276
Open
Pietrodjaowjao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ClassInjectordoes not propagate the base class'shas_referencesflag or update it when adding reference-containing fields to an injected class.In addition,
Il2CppReferenceField.Set()andIl2CppStringField.Set()write object pointers directly:This bypasses IL2CPP's GC write barrier. Together, the incorrect class metadata and raw reference writes can cause the collector or Unity liveness processing to miss objects reachable through injected fields. Those objects may then be reclaimed while still referenced, resulting in intermittent native access violations.
This is mostly relevant for injected types that inherit from base classes containing references.
Change
has_referencesfrom the injected class's base class.has_referenceswhen an injected field is:il2cpp_gc_wbarrier_set_fieldwhen assigning injected reference and string fields.HasReferencesthroughINativeClassStruct.Classes without references retain their previous metadata and layout. Unity versions without the write-barrier export retain the previous field-write behavior through the fallback, so existing setups remain unaffected.