Theme/tokyonight

[hiedanoajuu]

Description

Add a new theme tokyonight for bash-it.

Motivation and Context

Based on bash-it's easy theme, this theme tokyonight replicates the look of Tokyo Night Preset for Starship.

How Has This Been Tested?

1. Add the following statements to your ~/.bashrc

export BASH_IT_THEME='tokyonight'

2. Reload your shell

. ~/.bashrc

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[hiedanoajuu]

It seems that go in the CI environment is too old to run shfmt. Perhaps it should be updated to 1.26.0 or higher.

[BarbUk]

yeah, that's not good, the ci does a setup of a specific go version, but try to install the latest shfmt version.

I'll make a PR to fix that.

[hiedanoajuu]

yeah, that's not good, the ci does a setup of a specific go version, but try to install the latest shfmt version.

I'll make a PR to fix that.

Thanks so much.

[seefood]

merge from master now, #2405 fixed the CI.

[seefood]

sorry, I replied from the wrong user :)

[seefood]

Thanks for the theme! Found a couple of issues before this can merge:

Blocking — will fail CI

• themes/tokyonight/tokyonight.theme.bash:13 — . /etc/os-release triggers shellcheck SC1091 ("not following") with no disable comment. Every other file in the codebase that sources an external file (nvm.plugin.bash, rvm.plugin.bash, virtualenv.plugin.bash, powerline-naked.base.bash, etc.) adds # shellcheck disable=SC1091 for exactly this reason. Running shellcheck on this file locally confirms it exits non-zero, and there's no .shellcheckrc/severity override in this repo to mask it — the pre-commit shellcheck hook will fail on this PR as submitted.

Worth addressing

• Same line — sourcing /etc/os-release without localizing its variables leaks ID, NAME, VERSION, PRETTY_NAME, etc. into global scope, and re-parses the file on every single prompt render (since distro_prompt_info runs via PROMPT_COMMAND). Since the distro doesn't change during a session, consider caching the parsed value or scoping the variables to avoid polluting the user's shell namespace.

Nit

• docs/themes-list/tokyonight.rst:26 has trailing whitespace before the . ~/.bashrc code block (not CI-blocking, just a stray artifact).

Everything else looks good — shfmt is clean, no naming collisions with other themes' helper functions, and the RST doc renders correctly.

[hiedanoajuu]

Thanks a lot for the review. It is late here. I will address these issues tomorrow.

[hiedanoajuu]

I have addressed the issues mentioned above. Please review again.

[seefood]

not ideal but acceptable. LMK if you want me to merge or if you want to have another go at improving the metadata cache.

[seefood]

@hiedanoajuu still working on it or should I merge?

[hiedanoajuu]

I'm sorry that I have been busy with something else in the past few days. Please review it again.

[hiedanoajuu]

Is the metadata cache up to your expectations? Could you please merge it at your convenience?

[seefood]

Yup, it's great, just GitHub threw 503 at me. I'll try again.