fix(macos): tasks crash, liquid glass elements, chip motion - #12522
Merged
Conversation
TasksPage mounted a FlatList inside ShippingStage's Animated.View, which crashes react-native-macos on Home → Tasks. Render the list through ScrollView, keep task field access defensive for null or failed outcomes, and cover empty plus success renders. Failure-Class: new Verification: bun run --cwd react-native test -- src/desktop/DesktopApp.test.tsx __tests__/desktopReadClient.test.ts --runInBand Co-authored-by: Max Carter 祁明思 <max@tsc.hk>
Restore an even window-glass inset (top = sides = bottom) and match the Home spacer to AppDelegate positionOmiTrafficLights: leading 16, 14pt buttons, 8pt gaps, then the same leading after the cluster. Failure-Class: none Verification: bun run --cwd react-native test -- src/desktop/desktopChrome.test.ts src/ui/PageShell.test.tsx src/desktop/DesktopApp.test.tsx __tests__/macOSNativeBoundary.test.ts --runInBand Co-authored-by: Max Carter 祁明思 <max@tsc.hk>
Keep the window on a quiet UnderWindowBackground material and give nav, search, chips, stage, and composer their own NSGlassEffectView panels. HUD InkGlass is fallback-only so Tahoe no longer stacks two glasses into one smear. Type uses --lg-on-glass contrast. Failure-Class: none Verification: bun run --cwd react-native test -- src/desktop/DesktopApp.test.tsx src/desktop/desktopChrome.test.ts src/ui/PageShell.test.tsx __tests__/macOSNativeBoundary.test.ts --runInBand Co-authored-by: Max Carter 祁明思 <max@tsc.hk>
Home filters and Library hubs slide a glass pill behind the selected chip (120ms ease-out cubic). Reduce-motion snaps instantly instead of swapping chip backgrounds. Failure-Class: none Verification: bun run --cwd react-native test -- --runInBand Co-authored-by: Max Carter 祁明思 <max@tsc.hk>
undivisible
marked this pull request as ready for review
September 1, 2026 06:58
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_fb0c57a9-6e15-463d-95f2-fbaae9b7a879) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RN macOS only. Base is lowercase
v5(b61992ec). Four logical commits for rebase merge — do not squash. Nevermain. No necklace. No workers.dev default in source.1. Tasks crash
TasksPagemounted aFlatListinsideShippingStage'sAnimated.View, which crashes RnRuntime on react-native-macos. The list now renders throughScrollView.desktopTaskItemskeepsoutcomes === nulland failed reads as an empty list. Task row field access is defensive.Regression tests render Tasks with
outcomes === null, a failed outcome, and a success list, then walk Home → Tasks → Library → Rewind → Apps.2. Even traffic-light margins and top glass inset
desktopNavTopInsetis8, matching sides and bottom (desktopWindowInset). Native lights move with that inset:x = OmiWindowInset + OmiTrafficLightLeading,ysubtractsOmiWindowInset. The Home spacer is the measured cluster (3×14pt + 2×8pt) plus the same 16pt leading after the last light. Lights stay on the Home row.3. Per-element liquid glass
The window is a quiet
NSVisualEffectMaterialUnderWindowBackgroundbackdrop — not a full-bleedOmiGlassPanelView. Interactive pieces (nav, search, chips, stage, composer) each mount their ownOmiGlassPanel. On macOS 26 that isNSGlassEffectViewonly; HUD InkGlass is created only when the class is missing (no stacked HUD under Tahoe glass). Reduce Transparency stays opaque. Type uses--lg-on-glass(token.color.onGlass). Hairlines sit between nav, search, and stage.4. Sliding chip selection
Home filters and Library hubs slide a glass pill behind the selected chip (120ms ease-out cubic). Reduce-motion snaps instantly. Not a per-chip background swap.
Verification
147 tests passed, 0 lint errors,
tsc --noEmitclean.This Linux VM cannot open the live RnRuntime window. Confirm on a Mac: Tasks never crashes; even top glass padding; even light/Home spacing; distinct glass on nav/search/chips/stage; chips slide.