Fix external PR reviewer assignment - #20303
Conversation
Replace the non-collaborator team review request with explicit reviewer usernames. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fb00a3b8-0b0f-45e0-b788-8e1b53953043
|
Test this change out locally with the following install scripts (Action run 34631242476) VSCode
Azure CLI
|
| repo: context.repo.repo, | ||
| pull_number: context.payload.pull_request.number, | ||
| team_reviewers: ['bicep-external-maintainers'] | ||
| reviewers: [ |
There was a problem hiding this comment.
Can we not use a Github team here instead of naming people explicitly?
There was a problem hiding this comment.
Jared is working on optimizing the Bicep repo's teams and removing any extraneous teams, so I don't know if it's helpful to keep and maintain a group just for this auto-assign bot, which is really what we're only using this group for.
The solution was to just specify each engineer in the auto-assign bot instead of maintaining a group and its permissions.
Happy to discuss with you and Jared though if you have reservations
There was a problem hiding this comment.
Let's have a discussion - this team doesn't need permissions to anything, and could potentially be a sub-team of an existing team. I don't think this would introduce a whole lot of admin overhead, and avoids separately tagging each username on every PR.
Anthony Martin (anthony-c-martin)
left a comment
Anthony Martin (anthony-c-martin)
left a comment
There was a problem hiding this comment.
See comments
Remove stephaniezyen and clarify the reviewer assignment step name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fb00a3b8-0b0f-45e0-b788-8e1b53953043
2 participants
Summary
The listed engineers were taken from the current Bicep External Maintainers team membership and each has write access to the repository.
Follow-up to #19209.
Microsoft Reviewers: Open in CodeFlow