Skip to content

Group review-sdk failure issues instead of duplicating - #5137

Merged
Heath Stewart (heaths) merged 2 commits into
mainfrom
copilot/simorenoh-cosmos-vector-query-validation
Aug 27, 2026
Merged

Group review-sdk failure issues instead of duplicating#5137
Heath Stewart (heaths) merged 2 commits into
mainfrom
copilot/simorenoh-cosmos-vector-query-validation

Conversation

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

The Review SDK PR agentic workflow repeatedly failed with Engine Failure: The copilot engine terminated before producing output, each occurrence filing a new duplicate [aw] Review SDK PR failed issue.

Root cause

  • Job logs show the Copilot CLI resolves fine on the runner host, but the sandboxed awf-agent container (pinned gh-aw-firewall:0.27.44 image) fails to spawn /usr/local/bin/copilot inside itself: spawn /usr/local/bin/copilot ENOENT.
  • Since the process exits with no output, gh-aw's harness intentionally skips retrying (nothing to resume), surfacing as an immediate "Engine Failure".
  • This is a transient issue in the upstream gh-aw/gh-aw-firewall sandbox provisioning pipeline, not a bug in this repo's workflow definition — not something that can be reliably fixed by editing review-sdk.md.

Change

  • Enabled safe-outputs.group-reports: true in .github/workflows/review-sdk.md, the documented gh-aw mitigation for this exact scenario.
  • Future failures are now filed as sub-issues under a single parent [aw] Failed runs issue instead of spawning new top-level duplicates, while keeping failures visible.
  • Recompiled review-sdk.lock.yml via gh aw compile review-sdk; the diff is limited to GH_AW_GROUP_REPORTS flipping from "false" to "true" plus the expected frontmatter-hash update.
safe-outputs:
  group-reports: true
  create-pull-request-review-comment:
    ...

If the underlying ENOENT failure keeps recurring, it should be reported upstream to github/gh-aw, since the actual fix belongs in their sandbox/container provisioning.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
4 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI linked an issue Aug 26, 2026 that may be closed by this pull request
Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug workflow failure for SDK PR review Group review-sdk failure issues instead of duplicating Aug 26, 2026
@heaths
Heath Stewart (heaths) marked this pull request as ready for review August 26, 2026 23:28
Copilot AI balanced review requested due to automatic review settings August 26, 2026 23:28
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
3 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Groups recurring review-sdk failure reports under one parent issue to reduce duplicate top-level issues.

Changes:

  • Enables safe-outputs.group-reports.
  • Regenerates the compiled workflow artifact.
Show a summary per file
File Description
.github/workflows/review-sdk.md Enables grouped failure reporting.
.github/workflows/review-sdk.lock.yml Regenerated artifact; content excluded from review.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files excluded by content exclusion policy (1)
  • .github/workflows/review-sdk.lock.yml
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@heaths
Heath Stewart (heaths) enabled auto-merge (squash) August 26, 2026 23:54
@heaths
Heath Stewart (heaths) merged commit f46c8d9 into main Aug 27, 2026
18 checks passed
@heaths
Heath Stewart (heaths) deleted the copilot/simorenoh-cosmos-vector-query-validation branch August 27, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Review SDK PR failed

4 participants