-
Notifications
You must be signed in to change notification settings - Fork 363
implement identity bindings #5083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| ### Features Added | ||
|
|
||
| - Added support for Arc-connected servers when using the `ManagedIdentityCredential`. | ||
| - Added opt-in AKS identity binding support to `WorkloadIdentityCredentialOptions` through `enable_azure_proxy`. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I recommend spelling out "AKS" in any documentation at least the first time it's used. Better for SEO and for people who may not be as familiar with it. |
||
|
|
||
| ### Breaking Changes | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ azure_core = { path = "../../core/azure_core", version = "1.2.0-beta.1", default | |
| futures.workspace = true | ||
| openssl = { workspace = true, optional = true } | ||
| pin-project.workspace = true | ||
| reqwest = { workspace = true, optional = true, features = ["rustls"] } | ||
| serde.workspace = true | ||
| serde_json.workspace = true | ||
| time.workspace = true | ||
|
|
@@ -39,7 +40,8 @@ tokio.workspace = true | |
| tracing-subscriber.workspace = true | ||
|
|
||
| [features] | ||
| default = ["azure_core/default"] | ||
| default = ["azure_core/default", "azure_proxy"] | ||
| azure_proxy = ["dep:reqwest", "azure_core/reqwest_rustls"] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| tokio = ["dep:tokio", "azure_core/tokio", "tokio/process"] | ||
| client_certificate = ["openssl"] | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service directory "misspellings" should go into
sdk/identity/.cspell.json. There are agent instructions that help do this e.g., the/check-spellingskill.