Skip to content

{Storage} Fix Issues 32147 Add condition checking to avoid infinite loop #34173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiaSeng-v wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

{Storage} Fix Issues 32147 Add condition checking to avoid infinite loop #34173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5259c30
Fix Issues 32147: Add condition checking to avoid infinite loop
JiaSeng-v Oct 6, 2026
53548ca
stop directory walk before appending share root
JiaSeng-v Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/azure-cli/azure/cli/command_modules/storage/operations/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,8 @@ def _make_directory_in_files_share(file_service, directory_path, existing_dirs=N

parents = [directory_path]
p = os.path.dirname(directory_path)
while p:
# Stop once p reaches the root (dirname(p) == p), so the share root is never queued for creation
while p and p != os.path.dirname(p):
parents.append(p)
p = os.path.dirname(p)

Expand Down
Loading