[AKS] az aks update: Fix bug where autoscale profile boolean values could be incorrectly serialized as strings - #34058
Open
Matthew Christopher (matthchr) wants to merge 1 commit into
Conversation
Matthew Christopher (matthchr)
requested review from
a team and
FumingZhang
as code owners
September 10, 2026 23:03
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 10, 2026 23:03
microsoft-github-policy-service
Bot
added
Auto-Assign
Copilot started reviewing on behalf of
Matthew Christopher (matthchr)
September 10, 2026 23:04
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Fixes AKS autoscaler profile boolean serialization for az aks create and az aks update.
Changes:
- Converts supported string boolean values to booleans.
- Rejects invalid boolean values.
- Adds focused unit tests and updates type annotations.
File summaries
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py |
Tests boolean conversion, existing booleans, and invalid values. |
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py |
Normalizes and validates autoscaler boolean fields. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
AKS |
FumingZhang
approved these changes
Sep 11, 2026
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az aks update
az aks create
Description
Fix a bug in az aks update where string flags were not getting translated to booleans properly
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.