(chore): finish removing usage of "six" - #34054
Open
Alexandre Detiste (a-detiste) wants to merge 2 commits into
Open
(chore): finish removing usage of "six"#34054Alexandre Detiste (a-detiste) wants to merge 2 commits into
Alexandre Detiste (a-detiste) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution Alexandre Detiste (@a-detiste)! We will review the pull request and get back to you soon. |
Copilot started reviewing on behalf of
Alexandre Detiste (a-detiste)
September 10, 2026 16:27
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
six is still pinned in the Darwin/Windows requirements lockfiles, leaving the cross-platform removal incomplete and inconsistent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes remaining direct dependency and in-repo usage of six from Azure CLI packaging metadata and a storage command argument definition, continuing the long-running effort to eliminate six in Python 3-only code.
Changes:
- Dropped
sixfromsetup.pyinstall_requires. - Removed
sixfrom the Linux pinned requirements set. - Replaced
six.u-based argument type conversion withstrforaz storage message put/update --content.
File summaries
| File | Description |
|---|---|
| src/azure-cli/setup.py | Removes six from Azure CLI’s declared runtime dependencies. |
| src/azure-cli/requirements.py3.Linux.txt | Removes the pinned six entry from the Linux requirements lockfile. |
| src/azure-cli/azure/cli/command_modules/storage/_params.py | Eliminates a six import and uses str for message content argument typing. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
chore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History Notes
I've be doing this for a while: https://wiki.debian.org/Python3-six-removal , and I'd like to see the end of it.