{ACR} Upgrade azure-mgmt-containerregistry to 15.1.0b3 - #34053
Open
nihalvar wants to merge 9 commits into
Open
Conversation
added 5 commits
September 10, 2026 14:27
Capture the IDs returned by role assignment creation and use them for cleanup. Avoid enumerating unrelated inherited assignments, which can exceed the recorder's 128 KiB response limit.
Move the existing home-replication assertion after the first geo-replication is created, matching the observed service lifecycle. Preserve all zone redundancy assertions without adding retries or changing CLI behavior.
microsoft-github-policy-service
Bot
requested review from
Bin Du (northtyphoon) and
Terence Truong (terencet-dev)
September 10, 2026 11:40
Contributor
|
Automated sensitive-information remediation ran on this pull request.
X Engineering Agent does not modify source files. The PR creator must remove or replace each suspected value at the linked line:
If a credential was exposed, rotate or revoke it immediately. Detected values are never copied into this comment. ✅ Confirm the finding · ❌ Dispute the finding GitHub only supports a fixed reaction set, so 👍 represents ✅ and 👎 represents ❌. The bot-created reactions are only poll choices. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency bump is consistently applied across packaging files, and the accompanying test/recording updates are narrowly scoped to keep ACR playback stable with the new default API version.
Pull request overview
This PR upgrades the ACR management SDK dependency (azure-mgmt-containerregistry) to 15.1.0b3, aligning Azure CLI ACR management-plane calls with the SDK’s newer default API version (2026-09-01-preview), and refreshes ACR scenario recordings plus two targeted test adjustments to keep playback stable.
Changes:
- Bump
azure-mgmt-containerregistryfrom15.1.0b2to15.1.0b3acrosssetup.pyand platform requirements files. - Update ACR tests to (1) delete created role assignments by recorded IDs and (2) assert home replication zone redundancy after the first geo-replication is created.
- Re-record ACR scenario recordings to reflect the new API version and updated responses.
File summaries
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updates pinned azure-mgmt-containerregistry version to 15.1.0b3. |
| src/azure-cli/requirements.py3.windows.txt | Keeps Windows requirements in sync with the updated ACR SDK version. |
| src/azure-cli/requirements.py3.Linux.txt | Keeps Linux requirements in sync with the updated ACR SDK version. |
| src/azure-cli/requirements.py3.Darwin.txt | Keeps macOS requirements in sync with the updated ACR SDK version. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_task_abac_commands.py | Stabilizes RBAC test cleanup by deleting role assignments using returned assignment IDs. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_commands.py | Moves the home-replication zone redundancy assertion to after first geo-replication creation. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_check_name_availability.yaml | Re-recorded to use 2026-09-01-preview API version and updated headers. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_check_name_availability_dnl_scope.yaml | Re-recorded to use 2026-09-01-preview API version and updated response payload. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_with_public_network_access.yaml | Re-recorded to use 2026-09-01-preview API version and updated registry payload fields. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_with_public_network_access_disabled.yaml | Re-recorded to use 2026-09-01-preview API version and updated registry payload fields. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_with_dual_stack_endpoints.yaml | Adds/updates recording covering dual-stack endpoint protocol scenario under the new API version. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_login_expose_token.yaml | Re-recorded login/expose-token flow under the new API version. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_import_no_wait.yaml | Re-recorded import scenario; updates async operation URL API version to 2026-09-01-preview. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_export_policy.yaml | Re-recorded export policy scenario under the new API version. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_create_with_dual_stack_endpoints.yaml | Adds/updates recording for create-with-dual-stack-endpoints scenario under the new API version. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_create_with_domain_name_label_scope_name_in_use.yaml | Re-recorded; updates API version and observed RG create status/headers. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_create_with_data_endpoint.yaml | Adds/updates recording for data-endpoint enable/disable scenario under the new API version. |
Review details
- Files reviewed: 26/53 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
ACR |
nihalvar
requested review from
Greedygre (Greedygre),
Zunli Hu (Juliehzl) and
Hong Wang (howang-ms)
as code owners
September 11, 2026 02:27
This reverts commit 48144bd. undo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌AzureCLI-FullTest
Related command
az acrDescription
Upgrade
azure-mgmt-containerregistryfrom15.1.0b2to15.1.0b3insetup.pyand the Windows, Linux, and macOS requirements files. This updates the SDK's default management API from2026-03-01-previewto2026-09-01-preview.The SDK release primarily adds connected registry managed identity models and synchronization authentication support. This PR updates the dependency and regression coverage; it does not add new CLI commands or parameters.
Refresh the ACR scenario recordings and make two narrowly scoped test adjustments:
In
test_acr_rbac_auto_task, retain the IDs returned by role-assignment creation and delete those exact assignments. This avoids enumerating unrelated inherited assignments and exceeding the recorder's 128 KiB response limit.In
test_acr_with_zone_redundancy, check the home replication after creating the registry's first geo-replication. Live probes showed that the home replication resource is created at that point with both the old and new API versions. All existing zone-redundancy assertions are preserved, without retries or suppressed errors.The
@record_only()image-import scenario was also re-recorded separately. No CLI command implementation changes are included.Testing Guide
Run from the configured development environment:
PowerShell
Full ACR playback completed with 140 passed, 13 skipped, and no failures or errors. The style and command-linter checks passed. Updated scenarios were re-recorded against Azure before playback. The image-import scenario was recorded without
--live, with its previous cassette moved aside, because it is decorated with@record_only().These results cover the ACR module; they do not claim full cross-module CLI regression coverage.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.