Repository navigation
[Core] Remove AzureGermanCloud from hard-coded cloud list - #34042
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The removal is consistent and complete (no remaining references found), and the affected unit test was updated accordingly.
Pull request overview
This PR removes the retired Azure Germany cloud (AzureGermanCloud) from azure-cli-core’s hard-coded cloud definitions, and updates unit tests to use an alternative sovereign cloud (AzureUSGovernment) for active-cloud switching validation.
Changes:
- Removed
AzureGermanCloudfromCloudNameEnumand deleted the correspondingAZURE_GERMAN_CLOUDdefinition. - Removed
AZURE_GERMAN_CLOUDfromHARD_CODED_CLOUD_LIST, so it is no longer a built-in known cloud. - Updated
test_switch_active_cloudto switch toAzureUSGovernmentinstead of the removed cloud.
File summaries
| File | Description |
|---|---|
| src/azure-cli-core/azure/cli/core/cloud.py | Removes Azure Germany from the built-in cloud enum/definition and from the hard-coded known cloud list. |
| src/azure-cli-core/azure/cli/core/tests/test_cloud.py | Adjusts the active-cloud switching test to use an existing hard-coded cloud (AzureUSGovernment). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Azure Germany has been closed, so remove AzureGermanCloud from HARD_CODED_CLOUD_LIST while keeping the AZURE_GERMAN_CLOUD definition available. Update the affected test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ae0f081a-011a-4892-b82a-9261c9f3e44f
Yeming Liu (isra-fel)
force-pushed
the
hide-german-cloud
branch
from
September 8, 2026 04:06
3ae5a8d to
c998aca
Compare
Collaborator
|
Remove AzureGermanCloud |
Yeming Liu (isra-fel)
changed the title
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Ethan Yang (necusjz)
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Description
Azure Germany has been closed. This PR removes the
AzureGermanCloudentry from the hard-coded cloud list incloud.py:AzureGermanCloudfromCloudNameEnumAZURE_GERMAN_CLOUDClouddefinitionHARD_CODED_CLOUD_LISTtest_switch_active_cloudto useAzureUSGovernmentinstead of the removedAzureGermanCloudTesting
test_cloud.pypasses (14 passed, 1 skipped).