Donot error out if authorize_connect6 not found in legacy eBPF program - #398
Merged
Conversation
Copilot started reviewing on behalf of
Zhidong Peng (ZhidongPeng)
September 2, 2026 21:27
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new connect6-null handling can produce misleading “Found program” logs for a null pointer; the logging should be moved after the null check for accurate diagnostics.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Windows redirector’s eBPF attachment logic to tolerate legacy eBPF programs that don’t include the authorize_connect6 program, avoiding a startup failure while still attaching IPv4 where available.
Changes:
- Introduced shared constants for eBPF program and map names to avoid repeated string literals.
- Updated program attachment to skip (with a warning) when
authorize_connect6is not present (null program pointer) instead of erroring. - Replaced hard-coded map name strings with constants across policy/audit/skip-process map operations.
File summaries
| File | Description |
|---|---|
| proxy_agent/src/redirector/windows/bpf_prog.rs | Makes IPv6 program attachment optional for legacy eBPF objects and centralizes program/map name strings as constants. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Zhidong Peng (ZhidongPeng)
enabled auto-merge (squash)
September 2, 2026 23:30
Zhidong Peng (ZhidongPeng)
requested a review
from Srikrishna Veturi (srikrishnaveturi)
September 2, 2026 23:55
Srikrishna Veturi (srikrishnaveturi)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.