Skip to content

Donot error out if authorize_connect6 not found in legacy eBPF program - #398

Merged
Zhidong Peng (ZhidongPeng) merged 3 commits into
Azure:devfrom
ZhidongPeng:ipv6
Sep 3, 2026
Merged

Donot error out if authorize_connect6 not found in legacy eBPF program#398
Zhidong Peng (ZhidongPeng) merged 3 commits into
Azure:devfrom
ZhidongPeng:ipv6

Conversation

@ZhidongPeng

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new connect6-null handling can produce misleading “Found program” logs for a null pointer; the logging should be moved after the null check for accurate diagnostics.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Windows redirector’s eBPF attachment logic to tolerate legacy eBPF programs that don’t include the authorize_connect6 program, avoiding a startup failure while still attaching IPv4 where available.

Changes:

  • Introduced shared constants for eBPF program and map names to avoid repeated string literals.
  • Updated program attachment to skip (with a warning) when authorize_connect6 is not present (null program pointer) instead of erroring.
  • Replaced hard-coded map name strings with constants across policy/audit/skip-process map operations.
File summaries
File Description
proxy_agent/src/redirector/windows/bpf_prog.rs Makes IPv6 program attachment optional for legacy eBPF objects and centralizes program/map name strings as constants.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread proxy_agent/src/redirector/windows/bpf_prog.rs
Comment thread proxy_agent/src/redirector/windows/bpf_prog.rs
@ZhidongPeng
Zhidong Peng (ZhidongPeng) merged commit ba9b042 into Azure:dev Sep 3, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants