Skip to content

fix(noir): gate the release on noir bundle assets, not deprecated nargo ones #25499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Sep 17, 2026
+11 −9
Merged

fix(noir): gate the release on noir bundle assets, not deprecated nargo ones #25499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions noir/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ function install_native_from_release {
return 1
fi

# Place whatever noirup installed where the rest of the build expects it. The release ships nargo
# (and noir-profiler), but not noir-execute; its consumers fall back to the WASM simulator when
# absent.
# Place whatever noirup installed where the rest of the build expects it. noirup unpacks the
# release's `noir-<arch>-<platform>.tar.gz` bundle, which carries nargo, noir-execute,
# noir-profiler and noir-inspector; consumers of anything a given release omits fall back to the
# WASM simulator.
mkdir -p "$release_dir"
local bin
for bin in nargo noir-execute noir-profiler; do
Expand Down Expand Up @@ -193,25 +194,26 @@ function build {
exit 1
fi

# Check that the noir release has nargo binaries available for download. Without this check, we could push an aztec
# release that errors out with a 404/gzip error on install (the install scripts invoke noirup which would fail).
# Check that the noir release carries the `noir-<arch>-<platform>.tar.gz` bundles that noirup
# downloads. Without this check, we could push an aztec release that errors out with a 404/gzip
# error on install (the install scripts invoke noirup which would fail).
local noir_tag=$(git -C noir-repo describe --tags --exact-match HEAD)
echo "Checking noir release $noir_tag for nargo binary assets..."
echo "Checking noir release $noir_tag for noir bundle assets..."
local asset_count
asset_count=$(gh release view "$noir_tag" \
--repo noir-lang/noir \
--json assets \
--jq '[.assets[] | select(.name | test("^nargo-"))] | length') || {
--jq '[.assets[] | select(.name | test("^noir-.*\\.tar\\.gz$"))] | length') || {
echo_stderr "Error: Failed to query noir-lang/noir release '$noir_tag'. Does the release exist?"
exit 1
}
if [ "$asset_count" -eq 0 ]; then
echo_stderr "Error: Noir release '$noir_tag' exists but has no nargo binary assets."
echo_stderr "Error: Noir release '$noir_tag' exists but has no noir bundle assets."
echo_stderr "Users will get 404 errors when trying to install nargo via noirup."
echo_stderr "Ensure the noir release pipeline has finished uploading binaries before releasing aztec-packages."
exit 1
fi
echo "Found $asset_count nargo binary asset(s) in noir release $noir_tag."
echo "Found $asset_count noir bundle asset(s) in noir release $noir_tag."
fi

denoise "retry install_deps"
Expand Down
Loading