fix: disable ISO injection pending dual-boot safety guard - #1690
Closed
iesllc2026 wants to merge 1 commit into
Closed
fix: disable ISO injection pending dual-boot safety guard#1690iesllc2026 wants to merge 1 commit into
iesllc2026 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions
Summary
Temporarily disables Atlas ISO Injection because issue #1682 reports possible automatic whole-disk formatting and loss of non-Windows partitions in dual-boot configurations.
This is a fail-closed containment change. Normal live Playbook installation remains available.
Risk
The reported failure mode may cause irreversible loss of Linux installations and unrelated user data.
Root cause and ownership
Atlas packages the
.apbxPlaybook and opts it into ISO support through<SupportsISO>true</SupportsISO>. A repository-wide static search found no Atlas implementation of unattended Windows Setup, target-disk selection, partition selection, whole-disk wiping, or disk formatting.AME Beta/AME Wizard owns ISO injection, Windows Setup automation, target-disk selection, and any partition operations. Atlas therefore cannot repair the underlying installer behavior in this repository. This pull request contains the risk by opting Atlas out of ISO Injection until the responsible component has a verified partition-preservation fix.
Changes
src/playbook/playbook.conf: adds a concise issue [BUG] - ISO Injectjon attempts to format entire drive with no regards for a Linux dualboot #1682 safety comment and changes<SupportsISO>fromtruetofalse.<ISO>block remains unchanged. Official AME source definesSupportsISOas a boolean defaulting tofalse, keepsISOnullable independently, and performs ISO-specific validation only whenSupportsISOis true, so removal is not schema-required.Validation
All validation was static or packaging-only. No Playbook, ISO, Windows Setup, unattended installer, or disk command was executed.
git fetch --prune upstream; git fetch --prune origin— exit 0;HEAD,origin/main, andupstream/mainall resolved to1ed96306before the fix.gh issue view 1682 --repo Atlas-OS/Atlas --json ...plus the GitHub issue-comments API — issue open; issue body and all 3 comments reviewed.git grepforSupportsISO,<ISO>,ISO Injection,autounattend,unattend.xml,DiskConfiguration,WillWipeDisk,InstallTo,InstallToAvailablePartition,diskpart,select disk,clean,clean all,format,Clear-Disk,Remove-Partition, partition-selection logic, and unattended setup logic — only the playbook opt-in and optional ISO settings were relevant; no installer or destructive disk logic was found.gh search code SupportsISO --owner Ameliorated-LLCand officialPlaybook.csinspection throughgh api—SupportsISOis a boolean with defaultfalse;ISOis nullable; ISO-specific validation is guarded byif (SupportsISO).[xml](Get-Content src/playbook/playbook.conf -Raw)with property assertions — parsed successfully; exactly 1SupportsISOnode; boolean valueFalse; safety comment present; optionalISOblock present.yamllint -d "{extends: relaxed, rules: {empty-lines: disable, line-length: disable, new-line-at-end-of-file: disable, trailing-spaces: disable, new-lines: {type: platform}}}" .— exit 0, no findings.src/dependencies/local-build.ps1 -AddLiveLog -Removals WinverRequirement,Verification -DontOpenPbLocation -FileName "Atlas 1682 Validation"—Built successfully; archive size 48,024,818 bytes; SHA-256F600C0142BB65CECE4DDF9352BC75A787D15FF8C254A5621E6C13C1079139564.playbook.confparsed successfully; exactly 1SupportsISOnode with valuefalse; 0 matches for unattended wipe, disk-selection, or partition-deletion directives.git diff --check upstream/main..HEAD— exit 0, no whitespace errors.git diff --name-status upstream/main..HEAD— exactly 1 modified file:src/playbook/playbook.conf.autounattend,unattend.xml,DiskConfiguration,WillWipeDisk,InstallToAvailablePartition,diskpart,select disk,clean all,Clear-Disk, and theRemove-Partitioncommand — 0 matches.git status --short --branch— clean branch, 1 commit ahead ofupstream/mainbefore push.Upstream dependency
The complete repair belongs in AME Beta/AME Wizard or whichever component generates and drives Windows Setup. That component must prove it never assumes Disk 0, never schedules an unattended whole-disk wipe, requires explicit target-partition selection and confirmation, preserves all non-target partitions, aborts on ambiguity, and performs no disk modification on cancellation.
Re-enablement criteria
ISO Injection should not be restored until all of the following are verified:
Review process
This pull request should remain open for upstream review.
Do not merge it.
The project requires at least two reviews for non-team contributors, depending on the size of the change. The upstream maintainers will squash-merge it if accepted.