refactor: replace deprecated reg/sc/wmic/setx/schtasks with PowerShell cmdlets - #1648
Merged
Merged
Conversation
…l cmdlets and add inline comments
…y catches, process block, unused vars)
github-actions
Bot
added
playbook
Stensel8
commented
Apr 28, 2026
Contributor
Author
There was a problem hiding this comment.
Maybe use a preconfigured action for this, but this one seems unmaintained so I'm not sure.
https://github.com/marketplace/actions/run-psscriptanalyzer
The current method with the actions/checkout works fine though. It lints files correctly when ran on my fork.
TheyCreeper
approved these changes
Apr 28, 2026
jacksyrm
approved these changes
Apr 28, 2026
RadNotRed
approved these changes
Apr 30, 2026
Member
|
thank you! |
Contributor
Author
And thank you guys for the amazing project and actually making Windows the way it should've been in the first place! Haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces deprecated shell invocations with native PowerShell equivalents across the AtlasModules scripts, and adds PSScriptAnalyzer to CI.
Changes:
reg.exe add/delete→Set-ItemProperty/Remove-ItemProperty/Remove-Itemsc.exe config start=→Set-Service -StartupTypeGet-WmiObject→Get-CimInstancesetx→[Environment]::SetEnvironmentVariableschtasks /Change /Disable→Disable-ScheduledTask-EAalias →-ErrorActionDelete-UserChoiceKey→Remove-UserChoiceKey(unapproved verb)