Skip to content

fix: guard newUsers.ps1 against re-run after profile reset #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheyCreeper merged 7 commits into from
May 2, 2026
Merged

fix: guard newUsers.ps1 against re-run after profile reset #1644

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da2260f
fix: guard newUsers.ps1 against re-run after profile reset
Stensel8 Apr 27, 2026
5b7d62c
chore: add inline comments to SID guard
Stensel8 Apr 27, 2026
7de021c
fix: harden SID guard error handling and add comments
Stensel8 Apr 27, 2026
461732b
Replace reg.exe command with PowerShell cmdlets
Stensel8 Apr 28, 2026
9fbc728
Merge upstream new-update into fix/new-user-profile-reset-rerun
Stensel8 Apr 30, 2026
af8b37b
fix: replace empty catch with SilentlyContinue in SID guard
Stensel8 Apr 30, 2026
107577c
docs+fix: clarify SID guard comments, simplify marker write
Stensel8 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/playbook/Executables/AtlasModules/Scripts/newUsers.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Exit early if this SID was already set up — prevents re-running after an accidental profile reset
$sid = [System.Security.Principal.WindowsIdentity]::GetCurrent().User.Value
if ((Get-ItemProperty 'HKLM:\SOFTWARE\AtlasOS\UserSetup' -Name $sid -EA SilentlyContinue).$sid -eq 1) { exit }

$windir = [Environment]::GetFolderPath('Windows')
& "$windir\AtlasModules\initPowerShell.ps1"
$atlasDesktop = "$windir\AtlasDesktop"
Expand Down Expand Up @@ -73,6 +77,10 @@ if ([string]::IsNullOrWhiteSpace($browser)) {
& "$atlasModules\Scripts\taskbarPins.ps1" $browser
& reg.exe add "HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Search" /v "SearchboxTaskbarMode" /t REG_DWORD /d 1 /f *> $null

# Mark this SID as set up so the guard above triggers on any future re-run
New-Item 'HKLM:\SOFTWARE\AtlasOS\UserSetup' -Force | Out-Null
Set-ItemProperty 'HKLM:\SOFTWARE\AtlasOS\UserSetup' -Name $sid -Value 1 -Type DWord -Force

# Leave
Start-Sleep 5
Start-Sleep 5
logoff
Loading