Repository navigation
feat(frontend): add Storybook component catalog - #958
Merged
Dydex merged 1 commit intoOct 29, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #869. Adds Storybook 10 with 13 co-located stories covering 29 deterministic states for shared state, form, loan, governance, milestone, onboarding, notification, and transaction components. Storybook's axe accessibility checks are configured to fail the browser test suite on violations.
A pull-request workflow runs the Storybook tests and static build, uploads a 14-day preview artifact, and links it in the workflow summary. This repository has no configured public preview provider, so the artifact is downloadable but not a hosted live URL. See
docs/STORYBOOK.mdfor setup and authoring guidance.Testing
cd frontend && npm run test:storybook— passed (13 files, 29 tests, including axe checks).cd frontend && npm run build-storybook— passed. Vite emitteduse clientand large-chunk warnings.cd frontend && npm run type-check— passed.cd frontend && npm run lint -- .storybook 'src/components/**/*.stories.tsx' src/components/CreditMilestoneCard.tsx src/components/governance/QuorumProgressBar.tsx src/components/onboarding/ProgressStepper.tsx src/components/tx/TransactionResult.tsx— passed with one unused-import warning forCreditTierinCreditMilestoneCard.tsx.git diff --check— passed.Checklist
backend/src/test-utils/factories— no inline fixtures for these entities (seedocs/TEST_DATA_FACTORIES.md) — reviewed; not applicable to these frontend component stories (no backend entity tests were added).NEXT_PUBLIC_prefix and hold only public values — no browser-side variables were added.