Skip to content

feat(frontend): standardize destructive action confirmations - #956

Merged
Dydex merged 1 commit into
AstronLabs:mainfrom
Adedayo0101:feat/frontend-destructive-action-confirmation
Oct 29, 2026
Merged

Dydex merged 1 commit into
AstronLabs:mainfrom
Adedayo0101:feat/frontend-destructive-action-confirmation

Conversation

@Adedayo0101

@Adedayo0101 Adedayo0101 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Introduces a reusable, accessible confirmation dialog for destructive and high-impact actions.
  • Requires typed confirmation for irreversible financial and high-impact governance or administrative actions.
  • Migrates affected frontend workflows to use the shared dialog, with cancellation, focus management, loading states, and error handling.
  • Adds tests for confirmation behavior and migrated workflows.

Closes #868

Testing

  • Focused Jest tests passed (3 suites, 17 tests).
  • Frontend TypeScript check passed.
  • git diff --check passed.
  • Focused ESLint passed for the shared dialog and its tests.
  • Full changed-file ESLint: existing issues remain on unchanged lines in affected files.

Checklist

  • Tests cover the change.
  • Backend test-data factory requirements are not applicable; no loan, applicant, or milestone fixture tests were added.
  • No secrets or unintended client-side environment variables were introduced.
  • Documentation changes are not applicable; no documentation or configuration changes were included.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Dydex
Dydex merged commit e42a9be into AstronLabs:main Oct 29, 2026
35 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(frontend): Standardize Confirmation Dialogs for Destructive Actions

2 participants