fix(ci): cap pydantic-ai-slim below 2.34 in unit test requirements - #15701
Merged
Conversation
The unit-test tox env installs with -U and resolves pydantic-ai-slim fresh, so it picked up 2.34.0, whose source no longer matches the vendored data-stream protocol types in src/phoenix/db/types. test_data_stream_protocol_compatibility now fails on every PR (verified: 2.33.0 passes, 2.34.0 fails the request-type and schema parity tests). Cap the unit env at 2.33 parity until the vendored types are re-synced. Claude-Session: https://claude.ai/code/session_014gvDFFS2FTKCnjCnQpcdng
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
dosubot
Bot
added
the
size:XS
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
axiomofjoy
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR's unit tests currently fail on
unit/db/types/test_data_stream_protocol_compatibility.py: the toxunit_testsenv installs withuv pip install -Uand resolvespydantic-ai-slimfresh, and it now picks 2.34.0, whose source no longer matches the vendored data-stream protocol types insrc/phoenix/db/types.Verified deterministically: with 2.33.0 the three parity tests pass; with 2.34.0
test_vendored_request_types_match_pydantic_ai_sourceandtest_vendored_request_data_has_same_pydantic_schemafail.This caps the unit-test environment at 2.33 parity as a stopgap. The real fix is re-syncing the vendored types with upstream (the usual weekly dependency-upgrade flow), after which the cap should be lifted.
https://claude.ai/code/session_014gvDFFS2FTKCnjCnQpcdng