feat(online-evals): reorganize code evaluator form with shared authoring fields - #15696
Merged
mikeldking merged 2 commits intoAug 28, 2026
Merged
Conversation
…ing fields Moves the language and sandbox pickers into the Evaluator Code section header, extracts CodeAuthoringFields / CodeEvaluatorSourceEditor / CodeEvaluatorAnnotationSection into shared components used by both the create and edit code evaluator flows, unifies the span/session test panel branches behind EvaluatorSectionHeader, defers the scope filter into the preview queries, and syncs the mapping grain from the target-change handler instead of a render effect.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
…dking/15308-code-evaluator-details # Conflicts: # js/app/src/pages/project/evaluators/CreateProjectCodeEvaluatorDialogContent.tsx # js/app/src/pages/project/evaluators/CreateProjectEvaluatorSlideover.tsx
anticorrelator
added a commit
that referenced
this pull request
Aug 28, 2026
The rebase replayed this branch's evaluator-authoring arc over upstream's form reorganization (#15696), overlay fix (#15623), costs (#15638), and pxi meta-tools (#15316), which had rewritten the same surfaces. The authoring surface keeps this branch's dogfooded shape; upstream's additive module exports (getAnnotationLevel, status badge variant, detail-section primitives, language-swap guard) are ported onto it, the base-new detail/stats/costs pages are adapted to this branch's APIs, and the retired python draft tools stay deleted. The lockfile is deduped so @codemirror/view resolves once. Relay artifacts regenerated. Claude-Session: https://claude.ai/code/session_01Ne1haCNb9jSNo49HzV9wnM
anticorrelator
added a commit
that referenced
this pull request
Aug 28, 2026
The rebase replayed this branch's evaluator-authoring arc over upstream's form reorganization (#15696), overlay fix (#15623), costs (#15638), and pxi meta-tools (#15316), which had rewritten the same surfaces. The authoring surface keeps this branch's dogfooded shape; upstream's additive module exports (getAnnotationLevel, status badge variant, detail-section primitives, language-swap guard) are ported onto it, the base-new detail/stats/costs pages are adapted to this branch's APIs, and the retired python draft tools stay deleted. The lockfile is deduped so @codemirror/view resolves once. Relay artifacts regenerated. Claude-Session: https://claude.ai/code/session_01Ne1haCNb9jSNo49HzV9wnM
anticorrelator
pushed a commit
that referenced
this pull request
Aug 29, 2026
…ing fields (#15696) Moves the language and sandbox pickers into the Evaluator Code section header, extracts CodeAuthoringFields / CodeEvaluatorSourceEditor / CodeEvaluatorAnnotationSection into shared components used by both the create and edit code evaluator flows, unifies the span/session test panel branches behind EvaluatorSectionHeader, defers the scope filter into the preview queries, and syncs the mapping grain from the target-change handler instead of a render effect.
anticorrelator
added a commit
that referenced
this pull request
Aug 29, 2026
The rebase replayed this branch's evaluator-authoring arc over upstream's form reorganization (#15696), overlay fix (#15623), costs (#15638), and pxi meta-tools (#15316), which had rewritten the same surfaces. The authoring surface keeps this branch's dogfooded shape; upstream's additive module exports (getAnnotationLevel, status badge variant, detail-section primitives, language-swap guard) are ported onto it, the base-new detail/stats/costs pages are adapted to this branch's APIs, and the retired python draft tools stay deleted. The lockfile is deduped so @codemirror/view resolves once. Relay artifacts regenerated. Claude-Session: https://claude.ai/code/session_01Ne1haCNb9jSNo49HzV9wnM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15308.
Compacts the code evaluator form and consolidates its duplicated pieces into shared components used by every code evaluator flow (create dialog, edit slideover, and the standalone code evaluator dialog).
Layout
EvaluatorSectionHeadergains anextraslot), reclaiming a full row of vertical space. The header row wraps when the panel is resized narrow.hideLabelprop that swaps in anaria-label; default (vertical-form) usage keeps the visible labels and the required indicator.