Skip to content

feat(online-evals): reorganize code evaluator form with shared authoring fields - #15696

Merged
mikeldking merged 2 commits into
version-online-evalsfrom
mikeldking/15308-code-evaluator-details
Aug 28, 2026
Merged

feat(online-evals): reorganize code evaluator form with shared authoring fields#15696
mikeldking merged 2 commits into
version-online-evalsfrom
mikeldking/15308-code-evaluator-details

Conversation

@mikeldking

@mikeldking mikeldking commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator
Screenshot 2026-08-27 at 6 06 22 PM

Part of #15308.

Compacts the code evaluator form and consolidates its duplicated pieces into shared components used by every code evaluator flow (create dialog, edit slideover, and the standalone code evaluator dialog).

Layout

  • The Language and Sandbox pickers move into the top-right of the "Evaluator Code" section header (EvaluatorSectionHeader gains an extra slot), reclaiming a full row of vertical space. The header row wraps when the panel is resized narrow.
  • The pickers hide their visible labels in this compact placement via a new hideLabel prop that swaps in an aria-label; default (vertical-form) usage keeps the visible labels and the required indicator.

…ing fields

Moves the language and sandbox pickers into the Evaluator Code section
header, extracts CodeAuthoringFields / CodeEvaluatorSourceEditor /
CodeEvaluatorAnnotationSection into shared components used by both the
create and edit code evaluator flows, unifies the span/session test
panel branches behind EvaluatorSectionHeader, defers the scope filter
into the preview queries, and syncs the mapping grain from the
target-change handler instead of a render effect.
@mikeldking
mikeldking requested a review from a team as a code owner August 28, 2026 00:00
@github-project-automation github-project-automation Bot moved this to 📘 Todo in phoenix Aug 28, 2026
@dosubot dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 28, 2026
@claude

claude Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

…dking/15308-code-evaluator-details

# Conflicts:
#	js/app/src/pages/project/evaluators/CreateProjectCodeEvaluatorDialogContent.tsx
#	js/app/src/pages/project/evaluators/CreateProjectEvaluatorSlideover.tsx
@mikeldking
mikeldking merged commit d127bc6 into version-online-evals Aug 28, 2026
44 checks passed
@mikeldking
mikeldking deleted the mikeldking/15308-code-evaluator-details branch August 28, 2026 17:08
@github-project-automation github-project-automation Bot moved this from 📘 Todo to ✅ Done in phoenix Aug 28, 2026
anticorrelator added a commit that referenced this pull request Aug 28, 2026
The rebase replayed this branch's evaluator-authoring arc over upstream's
form reorganization (#15696), overlay fix (#15623), costs (#15638), and
pxi meta-tools (#15316), which had rewritten the same surfaces. The
authoring surface keeps this branch's dogfooded shape; upstream's
additive module exports (getAnnotationLevel, status badge variant,
detail-section primitives, language-swap guard) are ported onto it, the
base-new detail/stats/costs pages are adapted to this branch's APIs, and
the retired python draft tools stay deleted. The lockfile is deduped so
@codemirror/view resolves once. Relay artifacts regenerated.

Claude-Session: https://claude.ai/code/session_01Ne1haCNb9jSNo49HzV9wnM
anticorrelator added a commit that referenced this pull request Aug 28, 2026
The rebase replayed this branch's evaluator-authoring arc over upstream's
form reorganization (#15696), overlay fix (#15623), costs (#15638), and
pxi meta-tools (#15316), which had rewritten the same surfaces. The
authoring surface keeps this branch's dogfooded shape; upstream's
additive module exports (getAnnotationLevel, status badge variant,
detail-section primitives, language-swap guard) are ported onto it, the
base-new detail/stats/costs pages are adapted to this branch's APIs, and
the retired python draft tools stay deleted. The lockfile is deduped so
@codemirror/view resolves once. Relay artifacts regenerated.

Claude-Session: https://claude.ai/code/session_01Ne1haCNb9jSNo49HzV9wnM
anticorrelator pushed a commit that referenced this pull request Aug 29, 2026
…ing fields (#15696)

Moves the language and sandbox pickers into the Evaluator Code section
header, extracts CodeAuthoringFields / CodeEvaluatorSourceEditor /
CodeEvaluatorAnnotationSection into shared components used by both the
create and edit code evaluator flows, unifies the span/session test
panel branches behind EvaluatorSectionHeader, defers the scope filter
into the preview queries, and syncs the mapping grain from the
target-change handler instead of a render effect.
anticorrelator added a commit that referenced this pull request Aug 29, 2026
The rebase replayed this branch's evaluator-authoring arc over upstream's
form reorganization (#15696), overlay fix (#15623), costs (#15638), and
pxi meta-tools (#15316), which had rewritten the same surfaces. The
authoring surface keeps this branch's dogfooded shape; upstream's
additive module exports (getAnnotationLevel, status badge variant,
detail-section primitives, language-swap guard) are ported onto it, the
base-new detail/stats/costs pages are adapted to this branch's APIs, and
the retired python draft tools stay deleted. The lockfile is deduped so
@codemirror/view resolves once. Relay artifacts regenerated.

Claude-Session: https://claude.ai/code/session_01Ne1haCNb9jSNo49HzV9wnM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant