Skip to content

feat(evaluators): extend project empty state - #15686

Merged
yfrigui2 merged 3 commits into
version-online-evalsfrom
yasmine/project-evaluator-category-cards
Aug 28, 2026
Merged

feat(evaluators): extend project empty state#15686
yfrigui2 merged 3 commits into
version-online-evalsfrom
yasmine/project-evaluator-category-cards

Conversation

@yfrigui2

@yfrigui2 yfrigui2 commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add a dedicated empty-project evaluator header and a compact, accessible category carousel
  • link category cards and individual evaluator templates into URL-backed gallery selections
  • preserve gallery selection when nested creation slideovers close
  • preserve the existing populated evaluator table and toolbar treatment
  • share the project content max-width as a global text-width token
Screen.Recording.2026-08-27.at.11.14.46.AM.mov

@yfrigui2
yfrigui2 requested a review from a team as a code owner August 27, 2026 13:45
@github-project-automation github-project-automation Bot moved this to 📘 Todo in phoenix Aug 27, 2026
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 27, 2026
@claude

claude Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

yfrigui2
yfrigui2 commented Aug 27, 2026
View reviewed changes
Comment thread js/app/src/GlobalStyles.tsx
Comment on lines +92 to +93
// layout sizing
--global-text-content-max-width: 800px;

@yfrigui2 yfrigui2 Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickarize, let me know if this doesn't match what you had in mind

@mikeldking
mikeldking requested a review from a team as a code owner August 27, 2026 17:06
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 27, 2026
@yfrigui2
yfrigui2 force-pushed the yasmine/project-evaluator-category-cards branch from bf4cbbe to 84cd40c Compare August 27, 2026 18:17
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Aug 27, 2026
@rickarize rickarize mentioned this pull request Aug 27, 2026
Merged
@yfrigui2
yfrigui2 force-pushed the yasmine/project-evaluator-category-cards branch from 84cd40c to f94822b Compare August 28, 2026 19:11
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 28, 2026
@yfrigui2
yfrigui2 force-pushed the yasmine/project-evaluator-category-cards branch from f94822b to a8eebcf Compare August 28, 2026 19:58
@yfrigui2
yfrigui2 merged commit 942a829 into version-online-evals Aug 28, 2026
43 checks passed
@yfrigui2
yfrigui2 deleted the yasmine/project-evaluator-category-cards branch August 28, 2026 20:13
@github-project-automation github-project-automation Bot moved this from 📘 Todo to ✅ Done in phoenix Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rickarize rickarize

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

phoenix
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yfrigui2 @rickarize