fix(client): paginate large dataframe span exports - #15584
Open
Hasnaathussain wants to merge 1 commit into
Open
Conversation
Use the cursor-paginated span endpoint for unfiltered dataframe exports while preserving the SpanQuery DSL path. Add sync and async regression coverage for multi-page conversion. Signed-off-by: Hasnaat Hussain <hasnaat.hussain.2@gmail.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Author
|
The visible checks for #15584 (CLA, external-issue labeling, and the four Read the Docs builds) are green. The Python, TypeScript, Playwright, Semantic PR, Claude review, publish, zizmor, and phoenix-sqlean workflows are held in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11873
The common unfiltered
get_spans_dataframe()path now uses the existing cursor-paginated spans endpoint and combines all pages into the same dataframe shape. This avoids sending a large export through the legacy single-request query endpoint.Queries that use the SpanQuery DSL or
root_spans_onlykeep the legacy endpoint so their existing filtering semantics are unchanged. Both sync and async clients are covered.Verification: