Limit get_accounts_by_authorizers results - #2418
Closed
pur3miish wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 21, 2026
Author
|
Superseded by the maintained Spring implementation: AntelopeIO/spring#1894. The corresponding Spring issue is AntelopeIO/spring#1893. Closing this draft because Leap is no longer supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limittoget_accounts_by_authorizersmore: truewhen matching authorities were truncatedWhy
A public key can be assigned to an unusually large number of account permissions. The endpoint currently traverses and serializes every match, so a pathological or attacker-influenced authority set can consume significant CPU, memory, HTTP worker time, and bandwidth.
Applying a limit downstream does not protect nodeos because the complete response has already been generated. This change enforces the bound while iterating the node's authority index.
This addresses the node-side result-limit portion of #2417. Cursor pagination and cancellation-aware deadlines can be considered separately.
Validation
git diff --checkget_accounts_by_authorizers_limit_testfor truncated and complete resultsThe focused C++ test was not executed locally because this clean checkout does not include Leap's initialized submodules and pinned build toolchain; CI should compile and run it.