Use in_notebook() function instead of IN_NOTEBOOK constant - #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the module-level
IN_NOTEBOOKconstant with calls to thein_notebook()function so the notebook check is evaluated at call time rather than at import time.Changes
nbdev/serve.py:proc_nbsnow callsin_notebook()when choosing the parallel start methodnbdev/test.py:test_nbandnbdev_testnow callin_notebook()for SIGINT handling,IN_TESTenv var, and start method selectionnbdev/__init__.py: added a trigger note to thenbdev.skillmodule docsWhy
Evaluating at import time means the value is fixed regardless of the actual runtime environment (e.g. in spawned/forked workers, or when imported before a notebook kernel is established). Calling
in_notebook()gives the correct answer at the point of use.