Repository navigation
ci(bump): sign bump commits by creating them through the API - #5
Merged
Merged
Conversation
- Replace git push with a createCommitOnBranch GraphQL call so GitHub signs the commit. - Stop persisting checkout credentials and use BUMP_TOKEN only for the API call. - Update the README to describe the API commit and its verified status. Signed-off-by: igorjs <2278164+igorjs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump commits were pushed with plain
git, so they landed onmainunsigned. We want every commit onmainto show as verified, and commits created through the GitHub API are signed by GitHub.What Changed
createCommitOnBranchGraphQL mutation instead ofgit commitandgit push.marketplace.jsoncontents and uses the current head ofmainasexpectedHeadOid.mainmoved during the run, the API refuses the commit, the step fails with an error, and the next daily run retries.BUMP_TOKENis only passed to the commit step, with no fallback togithub.token.Notes for reviewers
workflow_dispatchrun after a new release is the way to check it, and the resulting commit should show as verified.