Skip to content

Data release 2026 - #463

Merged
rcpeene merged 74 commits into
devfrom
data_release_2026
Mar 4, 2026
Merged

rcpeene merged 74 commits into
devfrom
data_release_2026

Conversation

@rcpeene

@rcpeene rcpeene commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:00:59Z
----------------------------------------------------------------

It would be helpful to show the movie indices as growing color intensity instead of complete different colors. The design is to gradually change so that should be easier to see in the figure.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:01:00Z
----------------------------------------------------------------

Need more description of what you are doing here.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:01:00Z
----------------------------------------------------------------

Line #1.    def get_spike_matrix(stim_times, units_spike_times, bin_edges):

Please provide a function doctoring to ALL functions. Feel free to use AI to generate and correct


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:01:01Z
----------------------------------------------------------------

Let's try to fix the missing wheel and eye tracking data.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:09:55Z
----------------------------------------------------------------

Missing y axis and x axis label


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:09:56Z
----------------------------------------------------------------

We need to add a section to explain how the behavior works. Otherwise it is a bit confusing


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:09:57Z
----------------------------------------------------------------

Work with Roberto to include code to analyze behavior.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:09:57Z
----------------------------------------------------------------

We are missing the drug injection section, which is key.

Also those files include mice performing a behavior. We need to show those : Lick, water reward, running, etc...


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:09:58Z
----------------------------------------------------------------

Line #1.    def show_response(ax, window, window_start_time, window_end_time, aspect="auto", vmin=None, vmax=None, yticklabels=[], skipticks=1, xlabel="Time (s)", ylabel="ROI", cbar=True, cbar_label=None):

Add DocString throughout


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:09:59Z
----------------------------------------------------------------

Not great selection. Why are some units completely black


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:09:59Z
----------------------------------------------------------------

Explain which cell types are otto-tagged


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:10:00Z
----------------------------------------------------------------

Same as above, the image are not very convincing here. Would you agree? It could be a matter of changing the colorbar.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:18:00Z
----------------------------------------------------------------

You need to explain which mice are passive and which are active. Also many columns below look empty.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:18:01Z
----------------------------------------------------------------

Line #1.    # Function to convert string representation of a set to an actual set

Add docstring to all functions as for all notebooks.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:18:01Z
----------------------------------------------------------------

We should explain how to access image area location across all recording datasets.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:18:02Z
----------------------------------------------------------------

A bit hard to see across all plots. Perhaps the x window is too narrow? Maybe worth normalizing the c axis with a percentile value for each.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:18:03Z
----------------------------------------------------------------

0 cells. Maybe worth improving the code?

Also can you add behavior data. Some sessions are active sessions. This is entirely missing from the notebook


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:23:44Z
----------------------------------------------------------------

Lots of empty columns as for other notebooks.


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:23:45Z
----------------------------------------------------------------

We should add some text explaining a bit more how each mouse differs in genetic and indicator


@review-notebook-app

review-notebook-app Bot commented Feb 16, 2026 •

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2026-02-16T19:23:46Z
----------------------------------------------------------------

Line #4.    def plot_trace_over_epochs(trace_arrs, timestamps_arrs, epochs, time_start=None, time_end=None, title=None, trace_labels=None, yaxlabels=None, xlabel=None):

Please add doctoring to all functions


rcpeene and others added 29 commits February 26, 2026 11:08
Minor changes to response window extraction for clarity+RF/Responsiveness code
add ex responses to full-field dots
Replaced some analyses and added documentation to many sections.
Fix typo in GLO project description and improve clarity of predictive coding explanation
@rcpeene
rcpeene merged commit cd769b9 into dev Mar 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants