ops(0-0-0): post-#101 follow-up v2 — Copilot fixes + archives + GH_REPO + fork-naming rename (clean-base)

[AceHack]

Summary

Re-do of closed #102 (which had merge conflict from stale base). This v2 branches fresh from current AceHack/main + cherry-picks the 3 follow-up commits + addresses Aaron's just-arrived naming-convention correction.

What this PR does (4 commits)

1. Copilot fixes carry-forward (commit 74af746, originally for LFG ops(0-0-0): LFG forward-sync — post-reset cleanup + Copilot fixes + pr-preservation drain-logs (mirror of AceHack #101) Lucent-Financial-Group/Zeta#845): 4 Copilot threads from LFG ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory Lucent-Financial-Group/Zeta#844 addressed — internal-consistency on legacy DELETE response, "the only ruleset" wording, "task history: Otto-95 tick-close — 8th ferry absorbed; second SD-9 worked example Lucent-Financial-Group/Zeta#275" reference correction, gh api --input syntax. Now also on AceHack via this PR. Plus pr-preservation drain-logs for ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory Lucent-Financial-Group/Zeta#844 and ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #101.

2. Post-ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #101 Copilot fixes + full archives (commit 6d53733): 4 Copilot threads from AceHack ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #101 addressed — broken xref to user-scope-only memory file, internal-consistency duplicate, wording duplicate, MEMORY.md verbose-entry trim. Plus full PR archives at docs/pr-discussions/PR-0844-..., PR-0845-..., PR-acehack-0101-... (cross-fork-prefixed for AceHack).

3. GH_REPO env var support (commit 18c807f): tools/pr-preservation/archive-pr.sh now respects GH_REPO=<owner>/<name> env var as primary repo-resolution path, falling back to gh repo view. Per Aaron 2026-04-29 ask: "respect GH_REPO we should fix." Verified: GH_REPO=AceHack/Zeta tools/pr-preservation/archive-pr.sh 101 correctly resolves to AceHack instead of grabbing LFG/Zeta#101 (an unrelated PR).

4. Memory file rename (commit 5ba30cc): per Aaron 2026-04-29 "AceHack/Zeta we should not use a forks name in the main repo except for the special section for forks data that is unique to them like pr reviews, budgets, settings" — renamed memory/feedback_acehack_zeta_protection_config_* → memory/feedback_protection_config_*. The memory directory is general substrate, not a fork-specific section. Updated cross-references in MEMORY.md + 3 archives + 2 drain-logs.

Naming-convention rule going forward (per Aaron 2026-04-29)

USE fork-prefix in:

• docs/pr-discussions/ (PR archives — fork-specific data)
• docs/pr-preservation/ (drain-logs — fork-specific data)
• Settings dirs / budget dirs / any fork-specific section

DO NOT USE fork-prefix in:

• memory/ (general substrate)
• src/, tools/, general docs/ (not fork-scoped)

A fork-name in a non-fork-section path is a discipline violation; fork-names are appropriate only where the data IS fork-specific by definition.

Backlog item created

Task Lucent-Financial-Group#313: Pre-fix + post-fix lint for fork-naming discipline. Aaron's standing ops principle: every substrate rule needs both a pre-commit hook (catches local edits) AND a CI lint (catches PR-stage). The fork-naming rule violation today happened because neither layer existed. Going forward, every new rule should be encoded with both lint layers before being considered "shipped."

Sequence

1. AceHack PR (this) → merge → AceHack/main advances
2. LFG forward-sync PR opens (next)
3. After both merge, Aaron EXECUTE for AceHack absorption of LFG squash-SHA
4. 0/0/0 fully closed; recovery-lane classification can start

Test plan

• All Copilot findings addressed (4 from ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory Lucent-Financial-Group/Zeta#844 carry-forward + 4 from ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #101 own threads)
• Full PR archives written for ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory Lucent-Financial-Group/Zeta#844, ops(0-0-0): LFG forward-sync — post-reset cleanup + Copilot fixes + pr-preservation drain-logs (mirror of AceHack #101) Lucent-Financial-Group/Zeta#845, AceHack ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #101 (cross-fork prefix)
• AceHack-ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #101 drain-log corrected to reflect actual 4-thread state
• GH_REPO env var support verified
• Memory file renamed per Aaron's fork-naming rule + cross-refs updated
• Backlog item filed for pre-fix + post-fix lint discipline
• Branch base = current AceHack/main (no conflict)
• CI green
• Copilot reviews resolved if any threads land

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Follow-up operational cleanup to preserve PR review artifacts, fix previously reported Copilot issues in protection-config memory/docs, and improve PR-archiving ergonomics across forks/renames.

Changes:

• Add GH_REPO=<owner>/<repo> override support to tools/pr-preservation/archive-pr.sh for cross-fork archiving.
• Rename/adjust protection-config memory + tighten wording/reference consistency, and update memory/MEMORY.md index entry.
• Add/refresh PR archives (docs/pr-discussions/**) and drain logs (docs/pr-preservation/**) for Lucent-Financial-Group#844/Lucent-Financial-Group#845/#101.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tools/pr-preservation/archive-pr.sh	Adds GH_REPO-based repo resolution path ahead of gh repo view.
memory/feedback_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md	Updates protection-config memory wording, command narrative, and cross-references.
memory/MEMORY.md	Updates the index entry to point at the renamed/updated memory file with a shorter summary.
docs/pr-preservation/lfg-844-drain-log.md	Adds preserved thread-by-thread drain log for LFG PR Lucent-Financial-Group#844.
docs/pr-preservation/acehack-101-drain-log.md	Adds preserved thread-by-thread drain log for AceHack PR #101.
docs/pr-discussions/PR-acehack-0101-ops-0-0-0-post-reset-cleanup-stale-prose-fixes-protection-co.md	Adds archived PR discussion for AceHack #101.
docs/pr-discussions/PR-0845-ops-0-0-0-lfg-forward-sync-post-reset-cleanup-copilot-fixes.md	Adds archived PR discussion for LFG Lucent-Financial-Group#845.
docs/pr-discussions/PR-0844-ops-0-0-0-post-reset-cleanup-stale-prose-fixes-protection-co.md	Adds archived PR discussion for LFG Lucent-Financial-Group#844.

Comments suppressed due to low confidence (1)

memory/feedback_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md:104

• P1: This claims memory/MEMORY.md has an index pointer to the non-in-repo feedback_aaron_visibility_constraint_no_changes_he_cant_see_2026_04_28.md, but that filename doesn’t appear in memory/MEMORY.md (search shows no matches). Please either remove this clause or change it to point at the actual in-repo references that still mention the user-scope-only file.

[Copilot]

P1: GH_REPO validation is too permissive: values like /Zeta, AceHack/Zeta/extra, or AceHack/Zeta (trailing space) pass the current check and then fail later with a less actionable GraphQL error (or parse into an empty owner / invalid repo name). Consider validating GH_REPO strictly as owner/repo (exactly one slash, non-empty segments) and trimming surrounding whitespace before splitting into REPO_OWNER/REPO_NAME.

Suggested change

	REPO_NWO="${GH_REPO}"
	else
	REPO_NWO="$(gh repo view --json nameWithOwner --jq .nameWithOwner 2>/dev/null || true)"
	fi
	if [ -z "${REPO_NWO}" ] || [ "${REPO_NWO}" = "${REPO_NWO#*/}" ]; then
	echo "error: could not detect repo (need GH_REPO=<owner>/<name> env var or 'gh repo view' to succeed). Is gh authenticated and this a GitHub repo?" >&2
	exit 1
	fi
	REPO_NWO="$(printf '%s' "${GH_REPO}" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')"
	if ! [[ "${REPO_NWO}" =~ ^[^/[:space:]]+/[^/[:space:]]+$ ]]; then
	echo "error: GH_REPO must be exactly <owner>/<name> with one slash and non-empty segments (got: '${GH_REPO}')" >&2
	exit 1
	fi
	else
	REPO_NWO="$(gh repo view --json nameWithOwner --jq .nameWithOwner 2>/dev/null || true)"
	REPO_NWO="$(printf '%s' "${REPO_NWO}" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')"
	if ! [[ "${REPO_NWO}" =~ ^[^/[:space:]]+/[^/[:space:]]+$ ]]; then
	echo "error: could not detect repo (need GH_REPO=<owner>/<name> env var or 'gh repo view' to succeed). Is gh authenticated and this a GitHub repo?" >&2
	exit 1
	fi
	fi