Fix SonarCloud/pylint warnings#379
Conversation
aloysbaillet
force-pushed
the
fix/sonarcloud-cleanup
branch
from
e14e101 to
ae436f9
Compare
jfpanisset
left a comment
jfpanisset
left a comment
There was a problem hiding this comment.
Thank you for cleaning after me! Now that all packages are built as Conan packages, there's probably a bunch more cleanup to do, and opportunities to really leverage Conan to manage cross package dependencies.
|
Also for the build failure for the openssl wrapper: it recently was moved to ci-common since it is now a pre-requisite for building CMake (to have SSL support when CMake fetches packages itself). I think a "release" will be needed to create the corresponding Conan package on the Artifactory repository. The concept of a "release" may need to be revisited, as well as how Conan packages are versioned. |
|
Thanks JF, I thought I could start letting my spare Claude tokens help out when possible. |
…ated config Remove unused imports (os in utils.py, tempfile/os in test_utils.py), unused variable assignment in builder.py, unused arguments in deprecated CLI stubs, and deprecated ignore-mixin-members pylintrc option. Closes AcademySoftwareFoundation#377 Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aloysbaillet
force-pushed
the
fix/sonarcloud-cleanup
branch
from
ae436f9 to
13eb576
Compare
jfpanisset
left a comment
jfpanisset
left a comment
There was a problem hiding this comment.
Thank you very much for those cleanups.
I recently started paying more attention to SonarCloud scanning, especially since it now scans GitHub Actions workflows as well. But the recent commit to remove support for "container packages" clearly needed some work.
|
This branch is still marked as "draft", is it ready to merge? |
Originally submitted as [#379] but still marked Draft, need to fix failing CI. Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
|
I wanted to fix the CI Sonar job so I submitted this as #405 |
2 participants
Remove unused imports (os in utils.py, tempfile/os in test_utils.py), unused variable assignment in builder.py, unused arguments in deprecated CLI stubs, and deprecated ignore-mixin-members pylintrc option.
Closes #377