Skip to content

Add an adversarial and negative test suite for every money-moving path #847

New issue
New issue
Closed
#920
Closed
Add an adversarial and negative test suite for every money-moving path#847
#920
Assignees
stephanieefeakpokrire-droid
Labels
Stellar WaveIssues in the Stellar wave programdifficulty:hardHard difficulty issuetesting-and-qatesting-and-qa issue

Description

@thegreatfeez
thegreatfeez
opened on Oct 15, 2026

Testing & QA

Summary

Add tests that attempt to abuse every path that moves funds and assert each attempt is rejected.

Background

Happy-path tests dominate. Adversarial tests that try to over-spend, re-enter, or bypass limits are the ones that catch real vulnerabilities.

What Needs to Be Done

  1. Enumerate every path that moves funds.
  2. For each, add tests that attempt to bypass limits, approvals, or authorization.
  3. Assert each attempt is rejected and leaves state unchanged.
  4. Cover re-entry and replayed approvals.
  5. Fail loudly with a clear message when a rejection is missing.

Acceptance Criteria

  • Every money path has adversarial tests.
  • Each abuse attempt is rejected.
  • State is unchanged on rejection.
  • Tests pass with no unhandled cases.

Files to Look At

  • contracts/accord/src/lib.rs — money paths
  • contracts/accord/src/test.rs — tests
  • docs/SECURITY.md — threats

Difficulty: Hard

Activity

  1. thegreatfeez
    added
    difficulty:hardHard difficulty issue
    testing-and-qatesting-and-qa issue
    on Oct 15, 2026
  2. drips-wave
    added
    Stellar WaveIssues in the Stellar wave program
    on Oct 18, 2026

  3. Sensei-Victor commented on Oct 18, 2026

    @Sensei-Victor
    Sensei-Victor
    on Oct 18, 2026 – with Drips Wave

    @Sensei-Victor has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I can work on this
    Please assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Sensei-Victor to this issue.

  4. Emmycivity commented on Oct 18, 2026

    @Emmycivity
    Emmycivity
    on Oct 18, 2026 – with Drips Wave

    @Emmycivity has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’ve looked through the issue and have a good understanding of the requirements. I’m confident I can deliver the right solution without unnecessary complexity.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Emmycivity to this issue.

  5. Allen-altron commented on Oct 18, 2026

    @Allen-altron
    Allen-altron
    on Oct 18, 2026 – with Drips Wave

    @Allen-altron has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    . Hello, I’m interested in working on this issue. I have relevant experience and can get started as soon as possible

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Allen-altron to this issue.

  6. macsonfleek commented on Oct 18, 2026

    @macsonfleek
    macsonfleek
    on Oct 18, 2026 – with Drips Wave

    @macsonfleek has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, please assign me to this issue, I would love to work on it.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @macsonfleek to this issue.

  7. pchieneye commented on Oct 18, 2026

    @pchieneye
    pchieneye
    on Oct 18, 2026 – with Drips Wave

    @pchieneye has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi, I’ve carefully reviewed the issue and understand the expected outcome. I have the relevant experience to implement the solution and would be glad to take it on. Please assign it to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @pchieneye to this issue.

  8. stephanieefeakpokrire-droid commented on Oct 18, 2026

    @stephanieefeakpokrire-droid
    stephanieefeakpokrire-droid
    on Oct 18, 2026 – with Drips Wave
    Contributor

    @stephanieefeakpokrire-droid has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    maintainer assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @stephanieefeakpokrire-droid to this issue.

  9. thegreatfeez
    assigned
    stephanieefeakpokrire-droid
    on Oct 18, 2026

  10. drips-wave commented on Oct 18, 2026

    @drips-wave
    drips-waveBot
    on Oct 18, 2026 – with Drips Wave

    Congratulations, @stephanieefeakpokrire-droid! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @stephanieefeakpokrire-droid: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  11. stephanieefeakpokrire-droid commented on Oct 19, 2026

    @stephanieefeakpokrire-droid
    stephanieefeakpokrire-droid
    on Oct 19, 2026
    Contributor

    Resolved via PR #920

  12. thegreatfeez
    closed this as completedin #920on Oct 19, 2026

  13. drips-wave commented on Oct 19, 2026

    @drips-wave
    drips-waveBot
    on Oct 19, 2026 – with Drips Wave

    This issue has been completed by @stephanieefeakpokrire-droid as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @stephanieefeakpokrire-droid: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  14. emmanuelStack654
    added a commit that references this issue on Oct 20, 2026

    feat: adversarial tests, indexer load testing, RPC chaos resilience, …

    6e1dbe2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programdifficulty:hardHard difficulty issuetesting-and-qatesting-and-qa issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions