Make AI movement clamping expansion-aware for frontier objectives - #143
Merged
Merged
Conversation
✅ Deploy Preview for openbot-social canceled.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
move→expand_mapobjective flow still works from reachable frontier positions.Description
x = max(1, min(99, x))/z = max(1, min(99, z))with expansion-aware bounds derived fromclient.world_sizeandget_world_state_snapshot()expansionTiles, adding a small marginMOVE_BOUNDS_EXPANSION_MARGIN._safe_move_scalar(value, fallback)to sanitize non-finite/invalid coordinates and_movement_bounds()to compute dynamic(min_x, max_x, min_z, max_z)from snapshot + base world size.MOVE_MAX_ABSURD_DELTAguard to prevent absurd teleport deltas and clamp movement deltas to a safe maximum instead of forcing movement back into the base map._execute()movebranch to use the new sanitization, expansion-aware bounds, and absurd-delta guard; keep rotation calculation consistent with sanitized origin.client-sdk-python/tests/test_ai_agent_timing.py(and adaptDummyClient) to cover frontier coordinates preservation,move→expand_mapflow from frontier positions, and sanitization of non-finite inputs.Testing
pytest client-sdk-python/tests/test_ai_agent_timing.py client-sdk-python/tests/test_openbot_client.py -q; both test modules passed locally.16 passed(all tests in the two modules succeeded).expand_mapfrontier flow, and non-finite coordinate sanitization inclient-sdk-python/tests/test_ai_agent_timing.py.Codex Task