Skip to content

tests: find binaural goldens named <prefix>_rendered_binaural.wav #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trsonic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: find binaural goldens named <prefix>_rendered_binaural.wav #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/user_metadata_parsing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,20 @@ def get_test_combination_metadata(user_metadata_proto, test_file_directory):
golden_wav_path = os.path.join(
test_file_directory, golden_wav_file_name
)
# Some vectors store the binaural render under a layout-agnostic name
# (`<prefix>_rendered_binaural.wav`) instead of the
# `_rendered_id_..._layout_N.wav` convention. Fall back to it for
# binaural layouts so those vectors are not silently skipped.
if (
not os.path.exists(golden_wav_path)
and layout.loudness_layout.layout_type
== mix_presentation_pb2.LAYOUT_TYPE_BINAURAL
):
alt_file_name = f'{file_name_prefix}_rendered_binaural.wav'
alt_path = os.path.join(test_file_directory, alt_file_name)
if os.path.exists(alt_path):
golden_wav_file_name = alt_file_name
golden_wav_path = alt_path
bit_depth = 16
sample_rate = 48000
if os.path.exists(golden_wav_path):
Expand Down
Loading