Skip to content

Assert the avifROStream offset invariant #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WAM41 wants to merge 1 commit into from
+5 −0
Closed

Assert the avifROStream offset invariant #3349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/stream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,16 @@ void avifROStreamStart(avifROStream * stream, avifROData * raw, avifDiagnostics

avifBool avifROStreamHasBytesLeft(const avifROStream * stream, size_t byteCount)
{
// The subtraction below underflows unless the invariant documented in
// internal.h holds. Check it here so a violation aborts under assertions
// instead of silently returning AVIF_TRUE for any byteCount.
assert(stream->offset <= stream->raw->size);
return byteCount <= (stream->raw->size - stream->offset);
}

size_t avifROStreamRemainingBytes(const avifROStream * stream)
{
assert(stream->offset <= stream->raw->size);
return stream->raw->size - stream->offset;
}

Expand Down