Replace fnv-1a with crc32 hashing - #5401
Merged
Merged
Conversation
|
Do you have FG16 results for cpu2 and above? It seems the QP restriction in CPU1 is also removed. |
jingninghan
force-pushed
the
tx4
branch
2 times, most recently
from
September 12, 2026 15:25
9fdd2ba to
9f56eae
Compare
Contributor
Author
Please see the updated result numbers. Yes, i was hoping to remove its QP dependency if possible, as it would be helpful when the rate control kicks in later on. |
jingninghan
requested review from
jianle973,
leolzhao,
urvangjoshi,
yeqing-wu and
yunqingwang1
September 12, 2026 15:28
Performance change: sp1: 0.02% 98.29% sp2: +0.04% 97.79% sp3: +0.02% 97.16% sp4: +0.01% 98.37% Thanks to linzhen@google.com for evaluating the performance. STATS_CHANGED
yeqing-wu
enabled auto-merge (squash)
September 13, 2026 06:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.