Remove extra dc skip guard from the final encoding stage - #5365
Draft
jingninghan wants to merge 1 commit into
Draft
Remove extra dc skip guard from the final encoding stage#5365jingninghan wants to merge 1 commit into
jingninghan wants to merge 1 commit into
Conversation
jingninghan
requested review from
leolzhao,
urvangjoshi,
yeqing-wu and
yunqingwang1
September 2, 2026 23:18
yeqing-wu
reviewed
Sep 2, 2026
| cm->quant_params.base_qindex); | ||
| } | ||
| } | ||
| if (*eob == 1 && plane == 0) assert(tx_type == DCT_DCT); |
Contributor
There was a problem hiding this comment.
How about we improve this one so that we can avoid the condition check if it’s in release mode?
assert(!(*eob == 1 && plane == 0) || tx_type == DCT_DCT);
Contributor
There was a problem hiding this comment.
+1. You can even use the IMPLIES macro we have for this:
assert(IMPLIES(condition, statement));
Contributor
Author
There was a problem hiding this comment.
ack
I will put this on hold for now as unit test ran into failures.
jingninghan
marked this pull request as draft
September 3, 2026 03:55
The related functions were never called, as the mode search stage would ensure that if an intra block has eob is 1, its tx type must be 2D-DCT. Tested in speed 1 and 4 for a5, a4, and a2, no coding stats change.
jingninghan
marked this pull request as ready for review
September 8, 2026 23:29
jingninghan
marked this pull request as draft
September 9, 2026 04:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The related functions were never called, as the mode search stage would ensure that if an intra block has eob is 1, its tx type must be 2D-DCT.
Tested in speed 1 and 4 for a5, a4, and a2, no coding stats change.