fix(kernel): recover TraceLens reports after lost subagent completion - #1028
Open
akii96 wants to merge 1 commit into
Open
fix(kernel): recover TraceLens reports after lost subagent completion#1028akii96 wants to merge 1 commit into
akii96 wants to merge 1 commit into
Conversation
Resume aggregation when every subagent named at the final completion barrier already wrote complete findings. Signed-off-by: Aakif Nawaz <aakif.nawaz@amd.com>
akii96
force-pushed
the
fix/tracelens-aggregation-recovery
branch
from
July 24, 2026 19:34
2e8f442 to
5184fa6
Compare
akii96
marked this pull request as ready for review
July 24, 2026 19:44
Collaborator
|
@akii96 This seems to add a lot of bloat to the codebase. Can you pls let us know how often you saw this error? Can you let us know how to reproduce this? We'll try to test things out to see if anything can be done on the agent itself |
Author
|
@tsrikris Happened both the times I tested it might to do with the fact that I do not run InfX configs 🤔 Combined with my other PR #1029 which corrects the vllm upstream source export MODEL_PATH=MiniMaxAI/MiniMax-M3-MXFP8
export RUN_TAG="minimax-m3-mxfp8-c16-16k-$(date +%Y%m%d_%H%M%S)"
export RUN_DIR="$USER_DATA_PATH/optimizer_runs"
export RUN_LOG="$RUN_DIR/run_${RUN_TAG}.log"
export PID_FILE="$RUN_DIR/run_${RUN_TAG}.pid"
export LAUNCH_INFO="$RUN_DIR/launch_${RUN_TAG}.json"
mkdir -p "$RUN_DIR"
setsid nohup inference_optimizer -v optimize \
--model "$MODEL_PATH" \
--framework vllm \
--tp 4 \
--ep 1 \
--conc 16 \
--isl 16384 \
--osl 512 \
--profile-osl 512 \
--precision mxfp8 \
--max-model-len 82256 \
--max-hours 9 \
--tick-interval-sec 30 \
--enable-roofline \
--enable-conc-sweep \
--conc-sweep-concs 16,8,4 \
--conc-sweep-timeout-sec 600 \
--conc-sweep-total-budget-sec 1200 \
--phase-budget-prelude-pct 0.05 \
--phase-budget-framework-pct 0.08 \
--phase-budget-explore-pct 0.07 \
--phase-budget-kernel-pct 0.68 \
--phase-budget-sweep-pct 0.10 \
--phase-budget-close-pct 0.02 \
--skip-variants "add-shuffle-*,add-max-num-batched-tokens-32768,add-no-async-*,add-quick-reduce-*,add-fp8-kv-cache-*,add-indexer-kv-*" \
--target-summary "Optimize MiniMax-M3 MXFP8 text serving at TP4, concurrency 16, ISL 16384, OSL 512 on gfx950; use upstream vllm-project/vllm PR intelligence and prioritize MXFP8 linear, sparse-GQA, QuickReduce, and fused-MoE" \
--server-args "--distributed-executor-backend mp --trust-remote-code --block-size 128 --no-enable-prefix-caching --language-model-only --gpu-memory-utilization 0.95 --max-num-batched-tokens 32768 --max-num-seqs 64 --enable-chunked-prefill --long-prefill-token-threshold 32768 --attention-backend TRITON_ATTN --moe-backend aiter --linear-backend emulation --tool-call-parser minimax_m3 --enable-auto-tool-choice --reasoning-parser minimax_m3 --no-enable-log-requests" \
--launch-info-file "$LAUNCH_INFO" \
>"$RUN_LOG" 2>&1 </dev/null &
echo $! | tee "$PID_FILE"
echo "Log: $RUN_LOG"
echo "Launch info: $LAUNCH_INFO"This is how I setup my container whereby I take a vllm nightly image and setup hyperloom on it with all its dependecies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover TraceLens report generation when the parent workflow misses completion notifications from its final subagents.
Incident
During a real MI355X/vLLM optimization, the GEMM subagent completed and wrote a valid findings file:
However, approximately five minutes later, the parent still considered GEMM unfinished:
The SDK stream then ended without running the aggregation steps:
Because
analysis.mdis the authoritative TraceLens output, Hyperloom correctly refused to use the intermediate files. The optimization continued without a fresh kernel analysis, reducing the quality of downstream GEAK work.Fix
When this final-subagent barrier occurs, the runner now:
analysis.mdremains the only TraceLens result consumed by Hyperloom.Testing