Skip to content

feat: fix cavegenerator typo - #896

Merged
ACGaming merged 2 commits into
ACGaming:mainfrom
MCTian-mi:cavegen-perf-fixes
Aug 4, 2026
Merged

feat: fix cavegenerator typo#896
ACGaming merged 2 commits into
ACGaming:mainfrom
MCTian-mi:cavegen-perf-fixes

Conversation

@MCTian-mi

@MCTian-mi MCTian-mi commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

basically:

private void evaluatePond(World world, ChunkPrimer primer, Random rand, int x, int y, int z, int cX, int cZ) {
        int aX = cX * 16 + x;
-       int aZ = cZ * 16 + x;
+       int aZ = cZ * 16 + z;
        IBlockState candidate = primer.getBlockState(x, y - 1, z);
        // ...codes
}

@what-the-diff

what-the-diff Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR Summary

  • Incorporated a new supporting package pertinent to the Cave Generator plugin in the project's management file.
  • Adjusted project properties to include a debugging flag specifically for the Cave Generator plugin.
  • Expanded an existing configuration class to support a new category—CaveGeneratorCategory—featuring toggles for enabling performance enhancements as well as bug fixes.
  • Updated system loading procedures with a specific focus on the Cave Generator plugin, effectively allowing more granular control via the newly added configuration toggle.
  • Formulated a specialized class targeting Cave Generator, foremost tackling a specific bug pertaining to pond coordinates in the virtual environment.
  • Boosted language support by adding a new translation entry for the Cave Generator plugin in the English (US) localization file.
  • Introduced a new configuration descriptor for the Cave Generator plugin specifying how its various features should interact and integrate with the main application.

@ACGaming

ACGaming commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Nice, care to add a respective readme entry?

@MCTian-mi

Copy link
Copy Markdown
Contributor Author

Nice, care to add a respective readme entry?

done

@ACGaming
ACGaming merged commit c41b19f into ACGaming:main Aug 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants