Skip to content

Remove XMPP attendance query on join #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raucao merged 2 commits into from
Jul 9, 2026
Merged

Remove XMPP attendance query on join #316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f00acb
Remove XMPP attendance query on join
raucao Jul 9, 2026
93ce49f
Fix lint error
raucao Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions app/services/sockethub-xmpp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ export default class SockethubXmppService extends Service {
const channelId = message.target.id.split('/')[0];
const channel = this.coms.channels.find(ch => ch.sockethubChannelId === channelId);
if (channel) {
this.queryAttendance(channel);
this.queryRoomInfo(channel);
} else {
console.warn('Could not find channel for join message', message);
Expand Down Expand Up @@ -186,9 +185,8 @@ export default class SockethubXmppService extends Service {
channel.addUser(username);
}
}
} else {
this.log('xmpp', 'Presence update:', message.actor.id, message.object.presence, message.object.status);
}
this.log('xmpp', 'Presence update:', message.actor.id, message.object.presence, message.object.status);
}

/**
Expand Down Expand Up @@ -227,28 +225,6 @@ export default class SockethubXmppService extends Service {
}
}

/**
* Ask for a channel's attendance list (users currently joined)
*
* @param {Channel} channel
* @public
*/
queryAttendance (channel) {
let msg = this.buildActivityObject(channel.account, {
type: 'query',
target: {
id: channel.sockethubChannelId,
type: 'room'
},
object: {
type: 'attendance'
}
});

this.log('xmpp', 'asking for attendance list', msg);
this.sockethubClient.socket.emit('message', msg);
}

/**
* Ask for a channel's room info using service discovery
*
Expand Down
Loading