Repository navigation
bug: plugin.sh offered back a sibling host the cookie never reaches, and its finish skipped the Panel Plugins switch - #655
Merged
Conversation
…eaches, and its finish skipped the Panel Plugins switch The default host kept anything ending in the text of WEB_DOMAIN, so inventory-cs-panel.example.com was offered again beside cs-panel.example.com with no cookie domain covering it. Interactively it now offers a host the cookie reaches; an unattended run still never moves a host an earlier install chose, and a first install never keeps the example's host. The finish says to turn the Panel Plugins switch on, without which there is no Add button.
…e host, and the prompt never said why it offered another /dev/tty is mode 0666 even with no terminal to open (cron, ssh without -t), so -r passed, the read failed, and the new default moved the host unattended. unattended() now opens it. An interactive re-run says the current host is outside the cookie domain and what moving it takes, before asking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default host kept anything whose text ended in
WEB_DOMAIN, so a sibling likeinventory-cs-panel.example.comwas offered straight back even with no cookie domain covering it; and the closing steps sent operators to an Add button that doesn't exist until the Panel Plugins switch is on.<prefix>.<WEB_DOMAIN>is offered instead-y/ no terminal) runs never move a host an earlier install chose; the existing warning still firesaskreadsPLUGIN_TTYwhen set, so the tests can answer like a person; four new tests