Repository navigation
bug: update.sh narrowed a healthy dual-stack node's provided-node-ip on every run - #653
Merged
Merged
Conversation
…on every run, and misread quoted or commented node-ip values A healthy kubelet keeps provided-node-ip at the Tailscale IPv4 and IPv6 both; ensure_node_ip compared it to the IPv4-only config value, rewrote it each run and printed a false "moved". It now only acts when the first address differs. The node-ip value is read the way k3s's YAML allows (quotes, [list], trailing comment, spaces), and tests cover the retry and a refused annotate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #652: on a panel whose kubelet keeps
provided-node-ipat the Tailscale IPv4 and IPv6,ensure_node_ipcompared it to the IPv4-only config value, rewrote it on every./update.sh(dropping the IPv6 InternalIP until the kubelet put it back) and printed a false "moved".node-ipnode-ipthe way k3s's YAML allows: quotes,[list], trailing comment, spaces after commas--node-ip(including vpn-auth's IPv6) is on a local interface