Repository navigation
Bump gpu-kernels: 17a882640fa88 (its main), goldens re-recorded - #571
Conversation
config/gpu-kernels.config: 744bd713d968 -> 17a882640fa88e78ec92af42703a0707a6b7a061, the private HIP add-on's main (one-token MoE decode kernels, plus the DFlash2 verify/selector and NVFP4/Q2_0 work already on it; the add-on's addon.cmake and kernels/ are still there, which is what the config's `require` needs). Goldens are recorded at the release pin (docs/hw-gate.md), and they had to move twice over: they were last recorded at llama.cpp 8792923f, and #565 moved that pin to e7e5cd08, so the kat goldens and the KLD bases are re-recorded here with the new add-on. Re-recorded with `scripts/hw-gate.sh --phases build,kat --record` then `--phases kld --record` on Strix Halo, then checked back the same way: build, kat (7 models, 9 cases each) and kld (5 models) all PASS, KLD means <= 1e-6 with top-1 agreement 100%, 0 amdgpu ring timeouts. The five .kld bases live on the gate box, not in git (manifest.json pins their sha256); they are copied into ~/.cache/hw-gate/kld right after this merges, which is also when this PR's own hw_gate kld rows stop reporting a base mismatch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
PR Reviewer Guide 🔍(Review updated until commit 6e515e2)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 6e515e2 |
|
Merged as 0d0c846; the five So |
Moves the private HIP add-on's pin to its main:
config/gpu-kernels.configsha=744bd713d968…→sha=17a882640fa88e78ec92af42703a0707a6b7a061(one-token MoE decode kernels, on top of theDFlash2 verify/selector and NVFP4/Q2_0 work that was already there). Checked first that the new pin still satisfies the
config's
require=addon.cmake kernels— both are present.Goldens re-recorded, because they had to move on two counts.
tests/golden/hw-gate/manifest.jsonrecorded the lastset at llama.cpp
8792923f, and #565 moved that pin toe7e5cd08; with the add-on moving too, both thekatgoldens(7 models × 9 cases) and the KLD bases are re-recorded here:
The five
.kldbases are not in git (they live on the gate box;manifest.jsonpins their sha256). They are stagedin
~/wt/release-rc/hw-gate-store-pin/kldand get copied into~/.cache/hw-gate/kld/as soon as this merges —which is also the moment this PR's own
hw_gatekldrows stop reporting a base mismatch. Until then expect those rowsto fail with "base logits" and nothing else; it is not a real failure, and I will comment here when the bases are in
place.
Changed files:
config/gpu-kernels.config,tests/golden/hw-gate/kat-*.json(7),tests/golden/hw-gate/manifest.json.python3 tools/copyright.py --checkrc=0. Not merged here.🤖 Generated with Claude Code