Skip to content

docs(ethreceipts): fix monitor comment wording #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmterrors wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(ethreceipts): fix monitor comment wording #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethreceipts/ethreceipts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ func (l *ReceiptsListener) listener() error {
// TODO/NOTE: perhaps in an extended node failure. could there be a scenario
// where filterer.Exhausted is never hit? and this subscription never unsubscribes..?
// TODO: we ultimately need to check the monitor and if we get no new blocks for a period
// of time, then we can assume node problems.. even more helpful woudl be if the monitor
// of time, then we can assume node problems.. even more helpful would be if the monitor
// gave us an error count of node failures, and we'd listen on that, and if we hit a threshold
// and our block number doesn't change after a period of time, then we return an error
// that we're exhausted due to a node failure.
Expand Down