From f3d0582a5a8f49a9163bfdf97a16f5eef0caa722 Mon Sep 17 00:00:00 2001
From: Jason Nochlin <hundredwatt@gmail.com>
Date: Tue, 30 Dec 2014 12:08:23 -0500
Subject: [PATCH 1/4] Add failing test for "\r\n" end of line case

---
 conformance/validate.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/conformance/validate.yml b/conformance/validate.yml
index f78b56e00..05328d2ec 100644
--- a/conformance/validate.yml
+++ b/conformance/validate.yml
@@ -33,6 +33,10 @@ tests:
       text: "A lie gets halfway around the world before the truth has a chance to get its pants on. \n-- Winston Churchill (1874-1965) http://bit.ly/dJpywL"
       expected: false
 
+    - description: "Valid Tweet: 140 characters (counting 2 character end-of-line as 1 character)"
+      text: "Lorem ipsum dolor sit amet consectetur adipiscing elit.\r\nCum sociis natoque penatibus et magnis dis parturient montes nascetur ridiculus mus."
+      expected: true
+
   usernames:
     - description: "Valid username: a-z < 20 characters"
       text: "@username"

From 82446fea18142f2ea8bcc744d4d71cce973766c6 Mon Sep 17 00:00:00 2001
From: Jason Nochlin <hundredwatt@gmail.com>
Date: Fri, 2 Jan 2015 19:31:57 -0500
Subject: [PATCH 2/4] Ruby: extract method for preparing the tweet text to be
 counted

---
 rb/lib/twitter-text/validation.rb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/rb/lib/twitter-text/validation.rb b/rb/lib/twitter-text/validation.rb
index 659da88b5..e299eef5f 100644
--- a/rb/lib/twitter-text/validation.rb
+++ b/rb/lib/twitter-text/validation.rb
@@ -25,9 +25,11 @@ module Validation extend self
     def tweet_length(text, options = {})
       options = DEFAULT_TCO_URL_LENGTHS.merge(options)
 
-      length = text.to_nfc.unpack("U*").length
+      clean_text = clean_tweet_text(text)
 
-      Twitter::Extractor.extract_urls_with_indices(text) do |url, start_position, end_position|
+      length = clean_text.unpack("U*").length
+
+      Twitter::Extractor.extract_urls_with_indices(clean_text) do |url, start_position, end_position|
         length += start_position - end_position
         length += url.downcase =~ /^https:\/\// ? options[:short_url_length_https] : options[:short_url_length]
       end
@@ -109,5 +111,9 @@ def valid_match?(string, regex, optional=false)
 
       !(string && (!string.match(regex) || $~.to_s != string))
     end
+
+    def clean_tweet_text(text)
+      text.dup.to_nfc
+    end
   end
 end

From 068378256c9403b6bd90e7fea53331f8bfa9e5d3 Mon Sep 17 00:00:00 2001
From: Jason Nochlin <hundredwatt@gmail.com>
Date: Fri, 2 Jan 2015 19:32:59 -0500
Subject: [PATCH 3/4] Ruby: Replace "\r\n" with "\n"

---
 rb/lib/twitter-text/validation.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rb/lib/twitter-text/validation.rb b/rb/lib/twitter-text/validation.rb
index e299eef5f..ada2cbdee 100644
--- a/rb/lib/twitter-text/validation.rb
+++ b/rb/lib/twitter-text/validation.rb
@@ -113,7 +113,7 @@ def valid_match?(string, regex, optional=false)
     end
 
     def clean_tweet_text(text)
-      text.dup.to_nfc
+      text.dup.to_nfc.gsub("\r\n", "\n")
     end
   end
 end

From 6d0afb5cfb300afbd6b459becca7b4a9a63f3fec Mon Sep 17 00:00:00 2001
From: Jason Nochlin <hundredwatt@gmail.com>
Date: Fri, 2 Jan 2015 19:36:01 -0500
Subject: [PATCH 4/4] JS: Replace "\r\n" with "\n"

---
 js/twitter-text.js | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/js/twitter-text.js b/js/twitter-text.js
index eb4132b8c..1b8c04994 100644
--- a/js/twitter-text.js
+++ b/js/twitter-text.js
@@ -1067,6 +1067,10 @@
     return text.replace(twttr.txt.regexen.non_bmp_code_pairs, ' ').length;
   };
 
+  twttr.txt.cleanTweetText = function(text) {
+    return text.replace("\r\n", "\n")
+  };
+
   twttr.txt.convertUnicodeIndices = function(text, entities, indicesInUTF16) {
     if (entities.length == 0) {
       return;
@@ -1249,9 +1253,10 @@
           short_url_length_https: 23
       };
     }
-    var textLength = twttr.txt.getUnicodeTextLength(text),
-        urlsWithIndices = twttr.txt.extractUrlsWithIndices(text);
-    twttr.txt.modifyIndicesFromUTF16ToUnicode(text, urlsWithIndices);
+    var cleanText = twttr.txt.cleanTweetText(text),
+        textLength = twttr.txt.getUnicodeTextLength(cleanText),
+        urlsWithIndices = twttr.txt.extractUrlsWithIndices(cleanText);
+    twttr.txt.modifyIndicesFromUTF16ToUnicode(cleanText, urlsWithIndices);
 
     for (var i = 0; i < urlsWithIndices.length; i++) {
     	// Subtract the length of the original URL