Skip to content

Commit 32cd5cf

Browse files
committed
Don't set failure to empty struct
1 parent a1ea5a6 commit 32cd5cf

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

‎chasm/lib/activity/activity.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ func (a *Activity) recordFailedAttempt(
352352
failure *failurepb.Failure,
353353
noRetriesLeft bool,
354354
) error {
355-
outcome := a.Outcome.Get(ctx)
356355
attempt := a.LastAttempt.Get(ctx)
357356
currentTime := timestamppb.New(ctx.Now(a))
358357

@@ -365,7 +364,6 @@ func (a *Activity) recordFailedAttempt(
365364
// If the activity has exhausted retries, mark the outcome failure as well but don't store duplicate failure info.
366365
// Also reset the retry interval as there won't be any more retries.
367366
if noRetriesLeft {
368-
outcome.Variant = &activitypb.ActivityOutcome_Failed_{}
369367
attempt.CurrentRetryInterval = nil
370368
} else {
371369
attempt.CurrentRetryInterval = durationpb.New(retryInterval)

0 commit comments

Comments
 (0)