From 57c18a8e10d687573d19771dc6cccef4e76517ac Mon Sep 17 00:00:00 2001 From: Bill Richards Date: Fri, 21 Nov 2025 12:27:08 -0700 Subject: [PATCH 1/3] Enhance comments in task_queue.proto for clarity Added comments to clarify the purpose of TaskQueueKind. --- temporal/api/enums/v1/task_queue.proto | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/temporal/api/enums/v1/task_queue.proto b/temporal/api/enums/v1/task_queue.proto index 100ca070a..9df0fda53 100644 --- a/temporal/api/enums/v1/task_queue.proto +++ b/temporal/api/enums/v1/task_queue.proto @@ -10,6 +10,10 @@ option ruby_package = "Temporalio::Api::Enums::V1"; option csharp_namespace = "Temporalio.Api.Enums.V1"; enum TaskQueueKind { + // Tasks from any non workflow task are unspecified. + // + // Task queue kind is used to differentiate whether a workflow task queue is sticky or normal. + // If a task is not a workflow task, Task queue kind will always be unspecified. TASK_QUEUE_KIND_UNSPECIFIED = 0; // Tasks from a normal workflow task queue always include complete workflow history // From 958275b26012248a3beb5ec9763ab7cffc329ce9 Mon Sep 17 00:00:00 2001 From: Bill Richards Date: Fri, 21 Nov 2025 12:50:17 -0700 Subject: [PATCH 2/3] Clarify comments in TaskQueueKind enum Updated comments for clarity in task_queue.proto --- temporal/api/enums/v1/task_queue.proto | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/temporal/api/enums/v1/task_queue.proto b/temporal/api/enums/v1/task_queue.proto index 9df0fda53..b54f8f18b 100644 --- a/temporal/api/enums/v1/task_queue.proto +++ b/temporal/api/enums/v1/task_queue.proto @@ -10,10 +10,11 @@ option ruby_package = "Temporalio::Api::Enums::V1"; option csharp_namespace = "Temporalio.Api.Enums.V1"; enum TaskQueueKind { - // Tasks from any non workflow task are unspecified. + // Tasks from any non workflow task may be unspecified. // - // Task queue kind is used to differentiate whether a workflow task queue is sticky or normal. - // If a task is not a workflow task, Task queue kind will always be unspecified. + // Task queue kind is used to differentiate whether a workflow task queue is sticky or + // normal. If a task is not a workflow task, Task queue kind will sometimes be + // unspecified. TASK_QUEUE_KIND_UNSPECIFIED = 0; // Tasks from a normal workflow task queue always include complete workflow history // From a2a3880ccaee0df9f2e10021d305c33b2836d840 Mon Sep 17 00:00:00 2001 From: Bill Richards Date: Fri, 21 Nov 2025 12:23:08 -0800 Subject: [PATCH 3/3] forgot to run make... --- openapi/openapiv2.json | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/openapi/openapiv2.json b/openapi/openapiv2.json index 56e41775c..f27cf1275 100644 --- a/openapi/openapiv2.json +++ b/openapi/openapiv2.json @@ -1490,7 +1490,7 @@ }, { "name": "taskQueue.kind", - "description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.", + "description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_UNSPECIFIED: Tasks from any non workflow task may be unspecified.\n\nTask queue kind is used to differentiate whether a workflow task queue is sticky or \nnormal. If a task is not a workflow task, Task queue kind will sometimes be \nunspecified.\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.", "in": "query", "required": false, "type": "string", @@ -5354,7 +5354,7 @@ }, { "name": "taskQueue.kind", - "description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.", + "description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_UNSPECIFIED: Tasks from any non workflow task may be unspecified.\n\nTask queue kind is used to differentiate whether a workflow task queue is sticky or \nnormal. If a task is not a workflow task, Task queue kind will sometimes be \nunspecified.\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.", "in": "query", "required": false, "type": "string", @@ -15498,8 +15498,7 @@ "TASK_QUEUE_KIND_STICKY" ], "default": "TASK_QUEUE_KIND_UNSPECIFIED", - "description": "The task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.", - "title": "- TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history" + "description": " - TASK_QUEUE_KIND_UNSPECIFIED: Tasks from any non workflow task may be unspecified.\n\nTask queue kind is used to differentiate whether a workflow task queue is sticky or \nnormal. If a task is not a workflow task, Task queue kind will sometimes be \nunspecified.\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities." }, "v1TaskQueueMetadata": { "type": "object",