Skip to content

Commit b740fd6

Browse files
committed
Merge branch 'master' into ss/rev-number-can-child
2 parents 063a3f0 + 29286dd commit b740fd6

5 files changed

Lines changed: 32 additions & 19 deletions

File tree

‎buf.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ breaking:
1414
ignore:
1515
- google
1616
- temporal/api/enums/v1/failed_cause.proto
17+
# TODO: remove this once the changes with WorkflowExecutionExtendedInfo.pause_info is merged
18+
- temporal/api/workflow/v1/message.proto
1719
lint:
1820
use:
1921
- DEFAULT

‎openapi/openapiv2.json‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1490,7 +1490,7 @@
14901490
},
14911491
{
14921492
"name": "taskQueue.kind",
1493-
"description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.",
1493+
"description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_UNSPECIFIED: Tasks from any non workflow task may be unspecified.\n\nTask queue kind is used to differentiate whether a workflow task queue is sticky or \nnormal. If a task is not a workflow task, Task queue kind will sometimes be \nunspecified.\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.",
14941494
"in": "query",
14951495
"required": false,
14961496
"type": "string",
@@ -5354,7 +5354,7 @@
53545354
},
53555355
{
53565356
"name": "taskQueue.kind",
5357-
"description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.",
5357+
"description": "Default: TASK_QUEUE_KIND_NORMAL.\n\n - TASK_QUEUE_KIND_UNSPECIFIED: Tasks from any non workflow task may be unspecified.\n\nTask queue kind is used to differentiate whether a workflow task queue is sticky or \nnormal. If a task is not a workflow task, Task queue kind will sometimes be \nunspecified.\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.",
53585358
"in": "query",
53595359
"required": false,
53605360
"type": "string",
@@ -15523,8 +15523,7 @@
1552315523
"TASK_QUEUE_KIND_STICKY"
1552415524
],
1552515525
"default": "TASK_QUEUE_KIND_UNSPECIFIED",
15526-
"description": "The task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities.",
15527-
"title": "- TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history"
15526+
"description": " - TASK_QUEUE_KIND_UNSPECIFIED: Tasks from any non workflow task may be unspecified.\n\nTask queue kind is used to differentiate whether a workflow task queue is sticky or \nnormal. If a task is not a workflow task, Task queue kind will sometimes be \nunspecified.\n - TASK_QUEUE_KIND_NORMAL: Tasks from a normal workflow task queue always include complete workflow history\n\nThe task queue specified by the user is always a normal task queue. There can be as many\nworkers as desired for a single normal task queue. All those workers may pick up tasks from\nthat queue.\n - TASK_QUEUE_KIND_STICKY: A sticky queue only includes new history since the last workflow task, and they are\nper-worker.\n\nSticky queues are created dynamically by each worker during their start up. They only exist\nfor the lifetime of the worker process. Tasks in a sticky task queue are only available to\nthe worker that created the sticky queue.\n\nSticky queues are only for workflow tasks. There are no sticky task queues for activities."
1552815527
},
1552915528
"v1TaskQueueMetadata": {
1553015529
"type": "object",
@@ -16841,6 +16840,10 @@
1684116840
"$ref": "#/definitions/v1RequestIdInfo"
1684216841
},
1684316842
"description": "Request ID information (eg: history event information associated with the request ID).\nNote: It only contains request IDs from StartWorkflowExecution requests, including indirect\ncalls (eg: if SignalWithStartWorkflowExecution starts a new workflow, then the request ID is\nused in the StartWorkflowExecution request)."
16843+
},
16844+
"pauseInfo": {
16845+
"$ref": "#/definitions/v1WorkflowExecutionPauseInfo",
16846+
"description": "Information about the workflow execution pause operation."
1684416847
}
1684516848
},
1684616849
"description": "Holds all the extra information about workflow execution that is not part of Visibility."
@@ -16966,10 +16969,6 @@
1696616969
"priority": {
1696716970
"$ref": "#/definitions/v1Priority",
1696816971
"title": "Priority metadata"
16969-
},
16970-
"pauseInfo": {
16971-
"$ref": "#/definitions/v1WorkflowExecutionPauseInfo",
16972-
"description": "Information about the workflow execution pause operation."
1697316972
}
1697416973
},
1697516974
"description": "Hold basic information about a workflow execution.\nThis structure is a part of visibility, and thus contain a limited subset of information."
@@ -17408,7 +17407,7 @@
1740817407
"revisionNumber": {
1740917408
"type": "string",
1741017409
"format": "int64",
17411-
"description": "Monotonic counter reflecting the latest routing decision for this workflow execution.\nUsed for staleness detection between history and matching when dispatching tasks to workers.\nIncremented when a workflow execution routes to a new deployment version, which happens \nwhen a worker of the new deployment version completes a workflow task.\nNote: Pinned tasks and sticky tasks send a value of 0 for this field since these tasks do not\nface the problem of inconsistent dispatching that arises from eventual consistency between \ntask queues and their partitions."
17410+
"description": "Monotonic counter reflecting the latest routing decision for this workflow execution.\nUsed for staleness detection between history and matching when dispatching tasks to workers.\nIncremented when a workflow execution routes to a new deployment version, which happens\nwhen a worker of the new deployment version completes a workflow task.\nNote: Pinned tasks and sticky tasks send a value of 0 for this field since these tasks do not\nface the problem of inconsistent dispatching that arises from eventual consistency between\ntask queues and their partitions."
1741217411
}
1741317412
},
1741417413
"description": "Holds all the information about worker versioning for a particular workflow execution.\nExperimental. Versioning info is experimental and might change in the future."

‎openapi/openapiv3.yaml‎

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14272,6 +14272,10 @@ components:
1427214272
Note: It only contains request IDs from StartWorkflowExecution requests, including indirect
1427314273
calls (eg: if SignalWithStartWorkflowExecution starts a new workflow, then the request ID is
1427414274
used in the StartWorkflowExecution request).
14275+
pauseInfo:
14276+
allOf:
14277+
- $ref: '#/components/schemas/WorkflowExecutionPauseInfo'
14278+
description: Information about the workflow execution pause operation.
1427514279
description: Holds all the extra information about workflow execution that is not part of Visibility.
1427614280
WorkflowExecutionFailedEventAttributes:
1427714281
type: object
@@ -14419,10 +14423,6 @@ components:
1441914423
allOf:
1442014424
- $ref: '#/components/schemas/Priority'
1442114425
description: Priority metadata
14422-
pauseInfo:
14423-
allOf:
14424-
- $ref: '#/components/schemas/WorkflowExecutionPauseInfo'
14425-
description: Information about the workflow execution pause operation.
1442614426
description: |-
1442714427
Hold basic information about a workflow execution.
1442814428
This structure is a part of visibility, and thus contain a limited subset of information.
@@ -14928,7 +14928,14 @@ components:
1492814928
completed, pending activities will start their next attempt on the new version.
1492914929
revisionNumber:
1493014930
type: string
14931-
description: "Monotonic counter reflecting the latest routing decision for this workflow execution.\n Used for staleness detection between history and matching when dispatching tasks to workers.\n Incremented when a workflow execution routes to a new deployment version, which happens \n when a worker of the new deployment version completes a workflow task.\n Note: Pinned tasks and sticky tasks send a value of 0 for this field since these tasks do not\n face the problem of inconsistent dispatching that arises from eventual consistency between \n task queues and their partitions."
14931+
description: |-
14932+
Monotonic counter reflecting the latest routing decision for this workflow execution.
14933+
Used for staleness detection between history and matching when dispatching tasks to workers.
14934+
Incremented when a workflow execution routes to a new deployment version, which happens
14935+
when a worker of the new deployment version completes a workflow task.
14936+
Note: Pinned tasks and sticky tasks send a value of 0 for this field since these tasks do not
14937+
face the problem of inconsistent dispatching that arises from eventual consistency between
14938+
task queues and their partitions.
1493214939
description: |-
1493314940
Holds all the information about worker versioning for a particular workflow execution.
1493414941
Experimental. Versioning info is experimental and might change in the future.

‎temporal/api/enums/v1/task_queue.proto‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ option ruby_package = "Temporalio::Api::Enums::V1";
1010
option csharp_namespace = "Temporalio.Api.Enums.V1";
1111

1212
enum TaskQueueKind {
13+
// Tasks from any non workflow task may be unspecified.
14+
//
15+
// Task queue kind is used to differentiate whether a workflow task queue is sticky or
16+
// normal. If a task is not a workflow task, Task queue kind will sometimes be
17+
// unspecified.
1318
TASK_QUEUE_KIND_UNSPECIFIED = 0;
1419
// Tasks from a normal workflow task queue always include complete workflow history
1520
//

‎temporal/api/workflow/v1/message.proto‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,6 @@ message WorkflowExecutionInfo {
9898

9999
// Priority metadata
100100
temporal.api.common.v1.Priority priority = 24;
101-
102-
// Information about the workflow execution pause operation.
103-
WorkflowExecutionPauseInfo pause_info = 25;
104101
}
105102

106103
// Holds all the extra information about workflow execution that is not part of Visibility.
@@ -129,6 +126,9 @@ message WorkflowExecutionExtendedInfo {
129126
// calls (eg: if SignalWithStartWorkflowExecution starts a new workflow, then the request ID is
130127
// used in the StartWorkflowExecution request).
131128
map<string, RequestIdInfo> request_id_infos = 7;
129+
130+
// Information about the workflow execution pause operation.
131+
WorkflowExecutionPauseInfo pause_info = 8;
132132
}
133133

134134
// Holds all the information about worker versioning for a particular workflow execution.
@@ -219,10 +219,10 @@ message WorkflowExecutionVersioningInfo {
219219
DeploymentVersionTransition version_transition = 6;
220220
// Monotonic counter reflecting the latest routing decision for this workflow execution.
221221
// Used for staleness detection between history and matching when dispatching tasks to workers.
222-
// Incremented when a workflow execution routes to a new deployment version, which happens
222+
// Incremented when a workflow execution routes to a new deployment version, which happens
223223
// when a worker of the new deployment version completes a workflow task.
224224
// Note: Pinned tasks and sticky tasks send a value of 0 for this field since these tasks do not
225-
// face the problem of inconsistent dispatching that arises from eventual consistency between
225+
// face the problem of inconsistent dispatching that arises from eventual consistency between
226226
// task queues and their partitions.
227227
int64 revision_number = 8;
228228
}

0 commit comments

Comments
 (0)