Skip to content

Commit 3ebdff4

Browse files
authored
Add reset_heartbeats field to ResetActivityExecutionRequest (#848)
This PR reverts "remove reset_heartbeats field in ResetActivityExecutionRequest (#820 e74dc68)" **What changed?** - Add reset_heartbeats field to ResetActivityExecutionRequest **Why?** - Parity with WFA - This product behavior makes sense: a user with a long-running activity using exponential backoff on attempt 10 may wish to reset the attempt counter in order that the next retry backoff is short, and yet preserve their checkpointed progress. **Breaking changes** No
1 parent 5fd4740 commit 3ebdff4

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

‎openapi/openapiv2.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12020,6 +12020,10 @@
1202012020
"requestId": {
1202112021
"type": "string",
1202212022
"description": "Used to de-dupe reset requests."
12023+
},
12024+
"resetHeartbeat": {
12025+
"type": "boolean",
12026+
"description": "Reset persisted heartbeat details.\nReset always resets the attempt counter. Passing this flag causes reset to additionally\ndiscard any persisted heartbeat details."
1202312027
}
1202412028
}
1202512029
},

‎openapi/openapiv3.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15529,6 +15529,12 @@ components:
1552915529
requestId:
1553015530
type: string
1553115531
description: Used to de-dupe reset requests.
15532+
resetHeartbeat:
15533+
type: boolean
15534+
description: |-
15535+
Reset persisted heartbeat details.
15536+
Reset always resets the attempt counter. Passing this flag causes reset to additionally
15537+
discard any persisted heartbeat details.
1553215538
ResetActivityExecutionResponse:
1553315539
type: object
1553415540
properties: {}

‎temporal/api/workflowservice/v1/request_response.proto‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2420,6 +2420,12 @@ message ResetActivityExecutionRequest {
24202420

24212421
// Used to de-dupe reset requests.
24222422
string request_id = 10;
2423+
2424+
// Reset persisted heartbeat details.
2425+
// Reset always resets the attempt counter. Passing this flag causes reset to additionally
2426+
// discard any persisted heartbeat details.
2427+
bool reset_heartbeat = 11;
2428+
24232429
}
24242430

24252431
// Deprecated. Use `ResetActivityExecutionRequest`.

0 commit comments

Comments
 (0)